| chat.freenode.net #tryton log beginning Wed Oct 26 00:00:01 CEST 2016 | ||
| 2016-10-26 00:05 -!- JosDzG(~Thunderbi@201.175.134.46) has joined #tryton | ||
| 2016-10-26 03:22 -!- robink_(~quassel@unaffilated/robink) has joined #tryton | ||
| 2016-10-26 03:25 -!- Pilou(~Pilou@rogoth.ir5.eu) has joined #tryton | ||
| 2016-10-26 03:25 -!- Pilou(~Pilou@pdpc/supporter/active/pilou) has joined #tryton | ||
| 2016-10-26 04:51 -!- JosDzG(~Thunderbi@187.154.88.150) has joined #tryton | ||
| 2016-10-26 07:49 -!- JanGB(~jan@ipservice-092-216-122-042.092.216.pools.vodafone-ip.de) has joined #tryton | ||
| 2016-10-26 07:50 -!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton | ||
| 2016-10-26 08:14 -!- rpit(~rpit@2a02:908:e672:1520:56ee:75ff:fe0d:d3c7) has joined #tryton | ||
| 2016-10-26 08:40 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton | ||
| 2016-10-26 08:51 -!- mrichez(~smuxi@mail.saluc.com) has joined #tryton | ||
| 2016-10-26 08:58 -!- g5pw(~g5pw@mittelab/sudo/g5pw) has joined #tryton | ||
| 2016-10-26 10:17 -!- nicoe(~nicoe@2a02:a03f:3058:bd00:ee55:f9ff:fe7b:f7ac) has joined #tryton | ||
| 2016-10-26 11:46 <pokoli> Anyone know which is this error related to? http://pastebin.com/kr1DCfc9 | ||
| 2016-10-26 11:48 <cedk> pokoli: I do not think you can pass argument to click | ||
| 2016-10-26 11:49 -!- ronaldm(c5d3d812@gateway/web/freenode/ip.197.211.216.18) has joined #tryton | ||
| 2016-10-26 11:50 <cedk> pokoli: indeed change is valid argument | ||
| 2016-10-26 11:50 <cedk> pokoli: did you override reset_bom? | ||
| 2016-10-26 11:52 <cedk> pokoli: it is probably 48ca7078f8ca | ||
| 2016-10-26 11:58 <cedk> but does it make sense to check button access on a button_change? | ||
| 2016-10-26 12:02 <pokoli> cedk: this is the standard production module. I didn't change anything of the scenario | ||
| 2016-10-26 12:02 <pokoli> ACTION checking | ||
| 2016-10-26 12:04 -!- csotelo(~csotelo@201.240.50.21) has joined #tryton | ||
| 2016-10-26 12:07 <pokoli> cedk: for me we can skip the button access on the button_change if transaction is readonly as on on_change | ||
| 2016-10-26 12:08 <pokoli> cedk: and furthermor:, they do not modify anything on server. Their modification will be checked by ir.model* checks when saved | ||
| 2016-10-26 12:08 <cedk> pokoli: https://bugs.tryton.org/issue5983 | ||
| 2016-10-26 12:09 <cedk> pokoli: the transaction is readonly by default see line 203 of modelview.py | ||
| 2016-10-26 12:13 <pokoli> cedk: then for me it's not needed to check access | ||
| 2016-10-26 12:13 <cedk> pokoli: but maybe it will be good to have the button rules on it | ||
| 2016-10-26 12:15 <pokoli> cedk: I don't see why we should define a rule for something that may not be saved (as the user may discard the changes) | ||
| 2016-10-26 12:15 -!- giovanni_(~giovanni@90.63.246.25) has joined #tryton | ||
| 2016-10-26 12:15 <giovanni_> Hi | ||
| 2016-10-26 12:17 <pokoli> Hi giovanni_ :) | ||
| 2016-10-26 12:18 <giovanni_> been a while :( | ||
| 2016-10-26 12:18 <cedk> pokoli: a kind of confirmation | ||
| 2016-10-26 12:20 <cedk> pokoli: but indeed I see one interest, it is that it is called with check_access after | ||
| 2016-10-26 12:23 <pokoli> cedk: don't understand | ||
| 2016-10-26 12:24 <cedk> pokoli: in ModelView.button func is called without _check_access | ||
| 2016-10-26 12:27 <cedk> pokoli: but indeed I think my thoughts will be part of a larger change which will make on_change* calls checked only on the border | ||
| 2016-10-26 12:34 <pokoli> cedk: after reading the issue you created, now I understand and I agree that it will be great to have such behaviour | ||
| 2016-10-26 12:38 <pokoli> cedk: the review fixed the production scenario, thanks! | ||
| 2016-10-26 13:04 -!- JosDzG(~Thunderbi@187.154.88.150) has joined #tryton | ||
| 2016-10-26 13:07 -!- mariomop(~quassel@186.153.92.202) has joined #tryton | ||
| 2016-10-26 13:09 -!- nicoe(~nicoe@host-85-201-184-151.dynamic.voo.be) has joined #tryton | ||
| 2016-10-26 13:34 -!- smarro(~sebastian@181.16.7.104) has joined #tryton | ||
| 2016-10-26 14:07 -!- JosDzG(~Thunderbi@187.154.88.150) has joined #tryton | ||
| 2016-10-26 14:15 -!- apostatize(~visavis@unaffiliated/apostatize) has joined #tryton | ||
| 2016-10-26 14:29 -!- udono(~udono@tmo-113-172.customers.d1-online.com) has joined #tryton | ||
| 2016-10-26 14:59 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has left #tryton | ||
| 2016-10-26 15:00 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton | ||
| 2016-10-26 15:19 -!- udono(~udono@tmo-113-172.customers.d1-online.com) has joined #tryton | ||
| 2016-10-26 16:12 -!- csotelo_at_work(~csotelo@179.43.97.40) has joined #tryton | ||
| 2016-10-26 16:17 -!- silwol(~silwol@80.66.37.182) has joined #tryton | ||
| 2016-10-26 16:42 -!- csotelo_at_work(~csotelo@190.42.17.32) has joined #tryton | ||
| 2016-10-26 17:16 -!- csotelo_at_work(~csotelo@179.43.97.40) has joined #tryton | ||
| 2016-10-26 18:10 -!- mariomop(~quassel@host4.186-108-114.telecom.net.ar) has joined #tryton | ||
| 2016-10-26 18:30 -!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton | ||
| 2016-10-26 18:55 -!- kstenger(~karla@r167-56-250-153.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-10-26 19:02 -!- niki(~niki@0x3e2c8684.mobile.telia.dk) has joined #tryton | ||
| 2016-10-26 20:34 -!- kstenger(~karla@r186-55-67-251.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-10-26 22:29 -!- cjbarnes18(~user@host86-158-93-69.range86-158.btcentralplus.com) has joined #tryton | ||
| 2016-10-26 22:42 -!- smarro(~sebastian@201.254.25.185) has joined #tryton | ||
| 2016-10-26 22:57 -!- JanGB(~jan@ipservice-092-216-122-042.092.216.pools.vodafone-ip.de) has joined #tryton | ||
| 2016-10-26 23:10 -!- nramirezuy(~nramirezu@r167-62-159-111.dialup.adsl.anteldata.net.uy) has joined #tryton |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!