| chat.freenode.net #tryton log beginning Mon Feb 2 00:00:02 CET 2009 | ||
| 2009-02-02 01:34 -!- FWiesing(n=Wiesinge@194.208.185.12) has left #tryton | ||
| 2009-02-02 05:11 -!- vengfulsquirrel(n=ian@c-71-202-125-182.hsd1.ca.comcast.net) has joined #tryton | ||
| 2009-02-02 05:11 -!- vengfulsquirrel(n=ian@c-71-202-125-182.hsd1.ca.comcast.net) has left #tryton | ||
| 2009-02-02 05:20 -!- yangoon(n=mathiasb@p549F7CDE.dip.t-dialin.net) has joined #tryton | ||
| 2009-02-02 07:25 -!- nicoe(n=nicoe@ip-80-236-193-136.dsl.scarlet.be) has joined #tryton | ||
| 2009-02-02 08:00 -!- enlightx(n=enlightx@host-78-13-119-242.cust-adsl.tiscali.it) has joined #tryton | ||
| 2009-02-02 08:06 -!- Gedd(n=ged@77.109.113.162) has joined #tryton | ||
| 2009-02-02 08:19 -!- carlos(n=carlos@89.7.24.44) has joined #tryton | ||
| 2009-02-02 08:31 -!- sharkcz(n=dan@plz1-v-4-17.static.adsl.vol.cz) has joined #tryton | ||
| 2009-02-02 08:49 -!- cedk(n=ced@gentoo/developer/cedk) has joined #tryton | ||
| 2009-02-02 09:47 -!- enlightx(n=enlightx@host198-42-static.85-94-b.business.telecomitalia.it) has joined #tryton | ||
| 2009-02-02 09:57 -!- LordVan(n=lordvan@gentoo/developer/LordVan) has joined #tryton | ||
| 2009-02-02 10:01 -!- LordVan(n=lordvan@gentoo/developer/LordVan) has joined #tryton | ||
| 2009-02-02 10:04 -!- Gedd(n=ged@ip-80-236-193-136.dsl.scarlet.be) has joined #tryton | ||
| 2009-02-02 10:08 -!- simahawk(n=simao@host-84-222-63-237.cust-adsl.tiscali.it) has joined #tryton | ||
| 2009-02-02 11:49 -!- Timitos(n=Timitos@88.217.184.172) has joined #tryton | ||
| 2009-02-02 11:49 -!- bechamel(n=user@85.201.86.139) has joined #tryton | ||
| 2009-02-02 12:47 -!- enlightx(n=enlightx@host-78-13-119-242.cust-adsl.tiscali.it) has joined #tryton | ||
| 2009-02-02 13:00 -!- jporcel(n=jporcel@62.57.72.13.static.user.ono.com) has joined #tryton | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1508:dfa3b49d1209 trytond/trytond/web_service/db.py: Use template0 when restoring database | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1509:102e1348acb0 trytond/trytond/tools/convert.py: Remove unused import | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1510:b07795fac9a7 trytond/trytond/ (21 files in 9 dirs): Add modelstorage and modeldb | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 374:a0c1b92f0d47 account/ (account.py journal.py move.py tax.py): Fix for new modeldb | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 260:c4743cf2265f account_invoice/ (invoice.py payment_term.py): Fix for new modeldb | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 58:96116eede04a analytic_account/account.py: Fix for new modeldb | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 39:c3676e3463cd analytic_invoice/invoice.py: Fix for new modeldb | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 40:560c972316a2 analytic_purchase/purchase.py: Fix for new modeldb | ||
| 2009-02-02 13:14 <CIA-10> tryton: ced roundup * #766/Exception: ('Argument must be string or unicode.', 'Traceback (most recent call last):\n File "/trytond/netsvc.py", line 282, i...: [resolved] Fix with changeset 53270480858f | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 32:0aa8ae67fa9a analytic_sale/sale.py: Fix for new modeldb | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 127:cbde71ecbb87 product/uom.py: Fix for new modelstorage | ||
| 2009-02-02 13:14 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 216:1bfc452d3eaf purchase/purchase.py: Fix for new modeldb | ||
| 2009-02-02 13:15 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 113:d03be09667ba sale/sale.py: Fix for new modeldb | ||
| 2009-02-02 13:15 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 474:53270480858f stock/ (location.py product.py): Fix for new view_header_get must return string for issue766 | ||
| 2009-02-02 13:15 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 475:970cf34ca7b1 stock/packing.py: Fix for new modeldb | ||
| 2009-02-02 13:15 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 61:23b942619d75 timesheet/line.py: Fix for new view_header_get must return string | ||
| 2009-02-02 13:21 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1173:9b9390ec9d0c tryton/tryton/gui/window/win_import.py: Improve memory used of import csv by removing StringIO | ||
| 2009-02-02 13:22 -!- BleSS(n=neo@69.Red-83-39-51.dynamicIP.rima-tde.net) has joined #tryton | ||
| 2009-02-02 13:28 <BleSS> I've seen a demo about how can be customized an openerp project | ||
| 2009-02-02 13:28 <BleSS> I'm supposed that can be made the same with tryton, doesn't? | ||
| 2009-02-02 13:34 <cedk> BleSS: globally, yes but there is some differences | ||
| 2009-02-02 13:36 <BleSS> does OpenObject framework is also used by tryton? | ||
| 2009-02-02 13:38 <BleSS> I was reading about differences between openerp and tryton, there are changes important and interesting overall related to conection/network | ||
| 2009-02-02 13:39 <carlos> BleSS: as far as I know, OpenObject is an abstraction of the TinyERP/Tryton infrastructure so we may say that Tryton uses a modified version of OpenObject framework | ||
| 2009-02-02 13:40 <carlos> well, is more correct to say that OpenObject is a modificed version of the original TinyERP/Tryton infrastructure | ||
| 2009-02-02 13:44 <BleSS> I question myself if those changes could not be sent to openerp, and avoid a fragmentation. (I mean to have a community greater) | ||
| 2009-02-02 13:45 <cedk> BleSS: we try it but it was not possible | ||
| 2009-02-02 13:45 <carlos> BleSS: well, Tryton is a fork of TinyERP with a lot of rewrites not small changes | ||
| 2009-02-02 13:46 <carlos> and then, TinyERP guys evolved their system to OpenObject | ||
| 2009-02-02 13:48 <BleSS> well, I need create/customize a little application (erm) abount accounts, reporting, etc | ||
| 2009-02-02 13:48 <BleSS> I want to know if is posstible also intryton | ||
| 2009-02-02 13:48 <cedk> BleSS: yes, it is possible to customize it | ||
| 2009-02-02 13:48 -!- nicoe(n=nicoe@ip-80-236-193-136.dsl.scarlet.be) has joined #tryton | ||
| 2009-02-02 13:49 <BleSS> well, then I'm going to startin by the developer manual, thanks | ||
| 2009-02-02 14:00 -!- ikks(n=igor@190.144.69.234) has joined #tryton | ||
| 2009-02-02 14:10 -!- BleSS(n=neo@69.Red-83-39-51.dynamicIP.rima-tde.net) has left #tryton | ||
| 2009-02-02 14:11 <carlos> Timitos: Hi, seems like the chart of accounts is working now. I moved all root types to a common parent as you suggested and seems like it works now (not sure whether that was the required fix or just a mix of different changes I did...) | ||
| 2009-02-02 14:11 <carlos> Timitos: but anyway, it works now :-P | ||
| 2009-02-02 14:12 <Timitos> carlos: great | ||
| 2009-02-02 14:12 <carlos> I'm now with the taxes part and it should be functional | ||
| 2009-02-02 14:12 <carlos> Timitos: however, I have a doubt about the way I wrote the chart of accounts | ||
| 2009-02-02 14:13 <carlos> Timitos: I have two chart of accounts, the regular one and a simplified version | ||
| 2009-02-02 14:14 <Timitos> carlos: Did you put them into one module? Is this needed? Perhaps it would be better to create two modules? | ||
| 2009-02-02 14:14 <carlos> the accounts are the same, but the simplified version have reports simplified, and thus, some account types are different from the regular one | ||
| 2009-02-02 14:15 <carlos> Timitos: well, you should use one or the other depending on your past year incomes and number of employees | ||
| 2009-02-02 14:16 <carlos> so I was thinking on adding a wizard to switch from one to the other | ||
| 2009-02-02 14:16 <carlos> and in Tryton you get different chart of accounts templates, so you choose the one you want to use, instead of having to look for all modules before you decide which one to use | ||
| 2009-02-02 14:18 <Timitos> carlos: hm. this is indeed a special feature for spain. in germany you should always keep the same chart if it is possible | ||
| 2009-02-02 14:21 <carlos> well, you cannot change it in the same year | ||
| 2009-02-02 14:22 <carlos> but I think it may be useful if you do a mistake and start with the wrong one | ||
| 2009-02-02 14:22 -!- LordVan(n=lordvan@gentoo/developer/LordVan) has joined #tryton | ||
| 2009-02-02 14:22 <carlos> given that the account numbers and usage is the same, and the only difference are the reports | ||
| 2009-02-02 14:23 <Timitos> carlos: yes. as only the reports are different there should be not so much to do. | ||
| 2009-02-02 14:24 <carlos> but I need both chart of accounts, right? there is no other easy way to do it in Tryton, isn't it? | ||
| 2009-02-02 14:25 <carlos> Timitos: also, I was thinking on adding another chart of accounts template for individuals that are their own company in the same module. Why do you think is better to split it? | ||
| 2009-02-02 14:25 <Timitos> carlos: i haven´t thought about that yet. | ||
| 2009-02-02 14:25 <carlos> ok | ||
| 2009-02-02 14:25 <carlos> I have it done anyway, so I could migrate it later if we find a good way to do it | ||
| 2009-02-02 14:26 <Timitos> carlos: for me i would prefer to split it into more modules. so i only have those accounts and account.types i really need. | ||
| 2009-02-02 14:27 <carlos> aren't those just templates until you create a chart of accounts for a company? | ||
| 2009-02-02 14:28 <Timitos> carlos: but are you able to select these charts by your needs? i haven´t tried that yet. perhaps your way will work too. | ||
| 2009-02-02 14:29 <carlos> Timitos: what I get right now is the same as having two different modules that provide a chart of accounts | ||
| 2009-02-02 14:29 <carlos> I get the basic chart of accounts that comes with Tryton by default | ||
| 2009-02-02 14:30 <carlos> + the German one (I activated it) | ||
| 2009-02-02 14:30 <carlos> + both chart of accounts that my module provides | ||
| 2009-02-02 14:30 <carlos> the only problem I had having both chart of accounts in the same module is that I had to use different IDs for the xml entries | ||
| 2009-02-02 14:31 <carlos> ACTION is using two different .xml files, one for each chart of accounts | ||
| 2009-02-02 14:39 <Timitos> ACTION is testing carlos account chart and has now a freezing client..... | ||
| 2009-02-02 14:40 <carlos> Timitos: I tested it with 1.0 series and it takes a while, but it never froze my client | ||
| 2009-02-02 14:41 <Timitos> carlos: i will try again | ||
| 2009-02-02 14:53 <carlos> ACTION -> out | ||
| 2009-02-02 14:53 <carlos> see you later | ||
| 2009-02-02 14:57 <Timitos> carlos: cu | ||
| 2009-02-02 15:21 <carlos> back | ||
| 2009-02-02 15:51 <carlos> Timitos: were you able to load my module or is it still causing problems? | ||
| 2009-02-02 15:51 <Timitos> carlos: it worked now. | ||
| 2009-02-02 15:51 <carlos> ok | ||
| 2009-02-02 15:51 <Timitos> carlos: it takes really much time. | ||
| 2009-02-02 15:52 <carlos> I guess that's because it's huge | ||
| 2009-02-02 15:52 <carlos> two 'big' chart of accounts... | ||
| 2009-02-02 15:52 <Timitos> it seems to be really huge. and i thought my one is already huge :-) | ||
| 2009-02-02 15:53 <carlos> It may be an argument to split it | ||
| 2009-02-02 15:53 <carlos> or maybe to improve the parser/importer performance :-P | ||
| 2009-02-02 15:53 <carlos> yeah, yours is also big | ||
| 2009-02-02 15:54 <carlos> in fact, yours is bigger than the ones from Spain | ||
| 2009-02-02 15:55 <Timitos> carlos: but mine does not take so much time. but i think this is because of your two charts in one module | ||
| 2009-02-02 15:56 <carlos> 449K vs 349K + 360K | ||
| 2009-02-02 15:56 <carlos> ACTION is talking about file size | ||
| 2009-02-02 16:20 -!- udono(n=udono@dynamic-unidsl-85-197-24-127.westend.de) has joined #tryton | ||
| 2009-02-02 17:09 -!- juanfer(n=juanfer@190.144.69.234) has joined #tryton | ||
| 2009-02-02 17:15 <cedk> carlos: I don't think it is the xml parser fault | ||
| 2009-02-02 17:15 <cedk> I think it is the insert into the database that is slow | ||
| 2009-02-02 17:15 <carlos> cedk: I was just joking | ||
| 2009-02-02 17:16 <carlos> I'm sure it's the database insert, it's a lot of information | ||
| 2009-02-02 17:16 <udono> carlos: how many records you try to insert? | ||
| 2009-02-02 17:17 <carlos> udono: it's a chart of accounts | ||
| 2009-02-02 17:17 <carlos> actually, two of them | ||
| 2009-02-02 17:17 <cedk> the main issue, I think it is that we create on INSERT per record | ||
| 2009-02-02 17:18 <bechamel> updating indexes and one by one insert are costly but i don't see a way to improve that | ||
| 2009-02-02 17:18 <cedk> in psycopg, there is the possiblity to make multiquery in one request | ||
| 2009-02-02 17:18 <bechamel> cedk: the problem is when there are reference for id that are in the same file | ||
| 2009-02-02 17:19 <carlos> the total number of <record> tags are 2084 in total (both chart of accounts) | ||
| 2009-02-02 17:19 <cedk> bechamel: to have multiqueries, we must create a new xml syntax | ||
| 2009-02-02 17:19 <carlos> and that's without the tax information | ||
| 2009-02-02 17:20 <carlos> cedk: I'm wondering, why are we using 'parent' references instead of nested tags? | ||
| 2009-02-02 17:22 <carlos> I'm not sure whether that's going to improve the performance, but at least nested tags seems more correct when using XML, don't you think so? | ||
| 2009-02-02 17:22 <cedk> carlos: no, because you can have many trees in one model | ||
| 2009-02-02 17:24 <bechamel> carlos, cedk and above all the xml reflect the db, parent is just a foreign key | ||
| 2009-02-02 17:25 <carlos> you said it, trees, without loops, right?, so that shouldn't be a problem... | ||
| 2009-02-02 17:25 <carlos> bechamel: so the XML is more an exported SQL table using XML instead of SQL | ||
| 2009-02-02 17:26 <bechamel> carlos: xml is a ready-to-be-imported-in-the-db file :) | ||
| 2009-02-02 17:27 <carlos> I guess the performance of the python code that process such xml file is better as it's right now than if it needs to map the nested tags to foreign keys | ||
| 2009-02-02 17:27 <cedk> carlos: we can have trees with loop | ||
| 2009-02-02 17:29 <carlos> cedk: really? in that case there is no way to use nested tags. I didn't get any loop in my chart of accounts neither I was able to image its utility, so I assumed there aren't such loops | ||
| 2009-02-02 17:29 <udono> We are using XML only for inserting data out of modules and via XMLrpc. For me it is not a problem, that it takes some time... | ||
| 2009-02-02 17:31 <carlos> udono: well, as I said, I was joking about improving its performance, given that the speed problem that Timitos got is easily fixable using different modules for different chart of accounts | ||
| 2009-02-02 17:33 <cedk> carlos: loop in account charts is forbidden but for other models it can be allowed | ||
| 2009-02-02 17:33 <carlos> ok | ||
| 2009-02-02 17:37 <cedk> carlos: by the way, we use a sax parser which has better performance on big file | ||
| 2009-02-02 17:39 <carlos> do you think the speed may change if I merge both xml files in a single one? | ||
| 2009-02-02 17:40 <cedk> carlos: no, I don't think it will be visible | ||
| 2009-02-02 17:40 <carlos> ok | ||
| 2009-02-02 17:40 <cedk> carlos: but I think like timitos, that it will be better to have two modules | ||
| 2009-02-02 17:41 <carlos> yeah, that's what I'm going to do | ||
| 2009-02-02 18:05 -!- simahawk(n=simao@host-84-222-63-237.cust-adsl.tiscali.it) has joined #tryton | ||
| 2009-02-02 18:31 <cedk> carlos: and by the way, the installation of a module is all in one transaction, so that can also slowdown the import process if there is a lot of data | ||
| 2009-02-02 18:32 <carlos> indeed | ||
| 2009-02-02 18:32 <Timitos> this is an important notice. yes | ||
| 2009-02-02 18:51 -!- vengfulsquirrel(n=ian@c-71-202-125-182.hsd1.ca.comcast.net) has joined #tryton | ||
| 2009-02-02 19:19 -!- FWiesing(n=Wiesinge@194-208-185-012.tele.net) has joined #tryton | ||
| 2009-02-02 19:43 -!- panthera(n=daniel@unable-to-package.org) has joined #tryton | ||
| 2009-02-02 19:47 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1328:3b386601061b trytond/trytond/ir/model.py: Restart cache on fields_view_get after model access change | ||
| 2009-02-02 19:47 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1329:201f5660bc9a trytond/trytond/osv/orm.py: Add missing fuzzy test in _where_calc and _order_calc for issue697 | ||
| 2009-02-02 19:47 <CIA-10> tryton: Bertrand Chenal <bch@b2ck.com> default * 1330:4a3b8eac3a13 trytond/trytond/tools/convert.py: | ||
| 2009-02-02 19:47 <CIA-10> tryton: xml import: Fetch the correct default value when a field belongs to | ||
| 2009-02-02 19:47 <CIA-10> tryton: the parent model of the record. | ||
| 2009-02-02 19:47 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1331:3f717d2af4a8 trytond/trytond/tools/convert.py: Use default value from base model before of inherit model for xml import | ||
| 2009-02-02 19:47 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1332:54e82a5ef3e0 trytond/trytond/res/user.py: Reset cache for check and fields_view_get when writing res.user | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1333:3c307125cf73 trytond/trytond/osv/orm.py: Disable by default sort on One2Many fields | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1334:72e1824a61bf trytond/trytond/osv/orm.py: | ||
| 2009-02-02 19:48 <CIA-10> tryton: Fix Modified Preorder Tree Traversal | ||
| 2009-02-02 19:48 <CIA-10> tryton: - _update_tree works if only one record has changed | ||
| 2009-02-02 19:48 <CIA-10> tryton: - can not use child_number in update but instead old_right - old_left | ||
| 2009-02-02 19:48 <CIA-10> tryton: - set old_left if the same than old_right | ||
| 2009-02-02 19:48 <CIA-10> tryton: - pre-select ids before update to prevent collision | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1335:d27fd05245e9 trytond/trytond/osv/orm.py: Don't loop on id in delete for _update_tree because _rebuild_tree will be called many times. | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1336:8c24e50b35ab trytond/trytond/ (ir/translation.py osv/osv.py): Fix Cacheable to prevent attributes collision | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1337:fc66b065fe66 trytond/trytond/web_service/db.py: Use template0 when restoring database | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 206:c890bd635857 account_invoice/invoice.py: If amount_to_pay_today is zero used amount_to_pay in pay invoice wizard | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 207:04fd17846df0 account_invoice/CHANGELOG: Add changelog | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 396:fd1c6a67a106 stock/packing.py: Missing context in assign_force of internal packing | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 397:e0aebda37086 stock/move.py: Set effective_date also for assigned moves | ||
| 2009-02-02 19:48 <CIA-10> tryton: Bertrand Chenal <bch@b2ck.com> default * 398:96d4068b9809 stock/packing.py: Fix warehouse default value: use list instead of string for domain. | ||
| 2009-02-02 19:48 <CIA-10> tryton: Bertrand Chenal <bch@b2ck.com> default * 399:f847ec3157f8 stock/packing.py: Fix on_change: clean location and address when custome/supplier is unset. | ||
| 2009-02-02 19:48 <CIA-10> tryton: Bertrand Chenal <bch@b2ck.com> default * 400:881e02314ff6 stock/packing.py: Fix: use sequence on inventory packing creation. | ||
| 2009-02-02 19:48 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1075:29471f54e330 tryton/tryton/gui/window/ (win_export.py win_import.py): Use None instead of False when calling fields_get for import/export for issue759 | ||
| 2009-02-02 19:49 <CIA-10> tryton: C?dric Krier <ced@b2ck.com> default * 1076:de86ed7470a2 tryton/tryton/gui/main.py: Add logout before backup database for issue763 | ||
| 2009-02-02 19:49 -!- panthera_(n=daniel@unable-to-package.org) has joined #tryton | ||
| 2009-02-02 20:11 -!- paola(n=paola@host-84-223-76-210.cust-adsl.tiscali.it) has joined #tryton | ||
| 2009-02-02 20:17 -!- cedk(n=ced@gentoo/developer/cedk) has joined #tryton | ||
| 2009-02-02 20:19 -!- cristi_an(i=5978d3ce@gateway/web/ajax/mibbit.com/x-b0defc9016238164) has joined #tryton | ||
| 2009-02-02 20:41 -!- Timitos(n=Timitos@88.217.184.172) has joined #tryton | ||
| 2009-02-02 20:53 -!- bechamel`(n=user@85.201.86.139) has joined #tryton | ||
| 2009-02-02 21:07 -!- enlightx_(n=enlightx@host-78-13-120-215.cust-adsl.tiscali.it) has joined #tryton | ||
| 2009-02-02 21:15 <cedk> vengfulsquirrel: ping | ||
| 2009-02-02 21:15 <vengfulsquirrel> cedk: Hey | ||
| 2009-02-02 21:16 <cedk> vengfulsquirrel: I checked your patches | ||
| 2009-02-02 21:16 <cedk> vengfulsquirrel: for check_type_for_moves | ||
| 2009-02-02 21:16 <cedk> in the search call, you set double [[]] | ||
| 2009-02-02 21:17 <cedk> this is not needed, one [] is enough | ||
| 2009-02-02 21:17 <cedk> and no need to set context=None in the call | ||
| 2009-02-02 21:18 <vengfulsquirrel> Hmm yeah but double [[]] is still okay right its just not the best? | ||
| 2009-02-02 21:19 <cedk> vengfulsquirrel: it will be slower | ||
| 2009-02-02 21:19 <cedk> and generate uggly SQL | ||
| 2009-02-02 21:19 <vengfulsquirrel> Okay noted | ||
| 2009-02-02 21:20 <cedk> vengfulsquirrel: if you fix those two remarks, you can generate the patch files for inclusion | ||
| 2009-02-02 21:20 <vengfulsquirrel> For the context=None, I read the coding guidelines and it said "Calling method with default values must explicitly use keywords arguments." | ||
| 2009-02-02 21:21 <vengfulsquirrel> Ha I think maybe I read too much into that, what is the context for ? | ||
| 2009-02-02 21:21 <cedk> vengfulsquirrel: when you have values but here you don't have any | ||
| 2009-02-02 21:22 <cedk> vengfulsquirrel: context is for contextual value, this can be used for many things like language, timestamp check, etc. | ||
| 2009-02-02 21:23 <cedk> vengfulsquirrel: so what we want to say by explicit call, it is that when you have a value for an args that is default, you must use "=" | ||
| 2009-02-02 21:23 <cedk> vengfulsquirrel: because like that we can change the argument order without any problems | ||
| 2009-02-02 21:23 <cedk> vengfulsquirrel: when you have the two patches, you can assign to me the issue | ||
| 2009-02-02 21:24 <cedk> vengfulsquirrel: and ping me | ||
| 2009-02-02 21:28 <vengfulsquirrel> cedk: Okay thanks, I think you meant "Never pass keyword arguments as positional arguments." | ||
| 2009-02-02 21:33 <cedk> vengfulsquirrel: yes | ||
| 2009-02-02 21:33 <cedk> vengfulsquirrel: you can update the wiki | ||
| 2009-02-02 21:33 <cedk> vengfulsquirrel: if you have better english sentence | ||
| 2009-02-02 21:54 -!- sharkcz(n=dan@plz1-v-4-17.static.adsl.vol.cz) has joined #tryton | ||
| 2009-02-02 22:47 -!- paola_(n=paola@host-84-223-76-210.cust-adsl.tiscali.it) has joined #tryton | ||
| 2009-02-02 22:47 -!- paola_(n=paola@host-84-223-76-210.cust-adsl.tiscali.it) has left #tryton | ||
| 2009-02-02 23:09 -!- tekknokrat(n=gthieleb@dslb-088-074-150-146.pools.arcor-ip.net) has joined #tryton | ||
| 2009-02-02 23:24 <CIA-10> tryton: vengfulsquirrel * r432 /wiki/CodingGuidelines.wiki: Cleared up arguments verbiage. |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!