| irc.libera.chat #tryton log beginning Tue Dec 5 12:10:01 AM CET 2023 | ||
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 23:58 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 23:58 | |
| -!- Pegasus_RPG(~Thunderbi@2600:4041:7a71:8100:b09e:31f9:52f3:598c) has joined #tryton | 01:03 | |
| -!- yangoon(~yangoon@pd9e4a09f.dip0.t-ipconnect.de) has joined #tryton | 02:55 | |
| -!- dotbit(~dotbit@dotbit.ro) has joined #tryton | 05:34 | |
| -!- springwurm(~springwur@2a01:76c0:100:f500:6438:a72f:d67:1d67) has joined #tryton | 06:32 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 07:14 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 07:14 | |
| -!- mrichez(~Maxime@mail.saluc.com) has joined #tryton | 07:25 | |
| -!- mrichez(~Maxime@mail.saluc.com) has joined #tryton | 07:37 | |
| -!- yangoon(~yangoon@pd9e4addb.dip0.t-ipconnect.de) has joined #tryton | 07:57 | |
| -!- udono(~udo@071-154-117-131.ip-addr.inexio.net) has joined #tryton | 08:08 | |
| -!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton | 08:26 | |
| dotbit | Hi, I have added autocomplete+default_get in party_ro module from local fisc. I am trying to get it to a reasonable quality for including upstream, but I have ways to go. | 08:35 |
|---|---|---|
| dotbit | https://foss.heptapod.net/tryton/tryton/-/blob/branch/default/modules/party/party.py#L342 | 08:35 |
| dotbit | It keeps bothering me why this function is defined, but I can not figure out how to reuse it when I redefine the classmethod in party_ro | 08:36 |
| dotbit | I do this: values = super().default_get(fields_names, with_rec_name=with_rec_name) | 08:36 |
| dotbit | Sorry, I meant result = super().autocomplete(text, domain=domain, limit=limit, order=order) | 08:37 |
| dotbit | and also to reuse the identifier_types, etc | 08:37 |
| cedk | dotbit: you can not reuse it because it is in the scope of the method | 08:49 |
| cedk | you have to write your own version | 08:50 |
| dotbit | cedk: I like the generic implementation in Model for autocomplete and default_get. Thank you for that. | 09:06 |
| dotbit | I think two features that could be added are wizzard to add new party from Parties, and also checking of existing parties. | 09:07 |
| pokoli | dotbit: there is a wizard to merge duplicated parties | 09:08 |
| dotbit | Regarding checking of existing parties I am a little worried about the way we are mixing model defaults (ex. from config) and things added in default_get from authorative source. | 09:08 |
| dotbit | pokoli: you mean Replace? | 09:10 |
| pokoli | dotbit: yes, the replace is used to fix duplicates | 09:13 |
| dotbit | cedk: understood, thank you | 09:22 |
| dotbit | in Romania I think we have something like siret, where the fiscal domicile of a company is linked to an address, it is the ro_onrc identifier. | 09:23 |
| dotbit | I am thinking it is a good idea to link that identifier to the address like siret, but I can not figure out where that is done inside party_siret | 09:24 |
| dotbit | pokoli: Maybe some functionality could be reused from there, maybe use it as an example. | 09:27 |
| pokoli | dotbit: I do not know which is the usage of siret as its specific for france. But from what I see in a quick look in the code it just adds a Function field to show the identifiers of addresses | 09:28 |
| pokoli | IIRC the identifiers on the address have been moved to party module | 09:29 |
| dotbit | pokoli: ah, I was looking in the wrong place. it works even without party_siret activated once configured, so you must be right | 09:33 |
| dotbit | thank you Sergi! | 09:34 |
| -!- acaubet1(~Thunderbi@194.224.31.235) has joined #tryton | 09:53 | |
| -!- Pegasus_RPG(~Thunderbi@2600:4041:7a71:8100:b09e:31f9:52f3:598c) has joined #tryton | 13:14 | |
| -!- springwurm(~springwur@2a01:76c0:100:f500:5c8f:8172:c579:de74) has joined #tryton | 13:18 | |
| -!- srgdts(~srgdts@user/srgdts) has joined #tryton | 17:56 | |
| -!- yangoon(~yangoon@p5dd084c6.dip0.t-ipconnect.de) has joined #tryton | 20:20 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!