| irc.libera.chat #tryton log beginning Wed Jul 26 12:10:02 AM CEST 2023 | ||
| -!- springwurm(~springwur@2a01:76c0:100:f500:1e74:d311:4d3a:3ae0) has joined #tryton | 05:08 | |
| -!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton | 07:21 | |
| -!- springwurm(~springwur@2a01:76c0:100:f500:2316:fad0:b324:cd70) has joined #tryton | 12:06 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 13:41 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 13:41 | |
| cedk | pokoli: if you keep skipping the review process, I will have no other option than remove you the pubisher right | 13:44 |
|---|---|---|
| pokoli | cedk: nothing will change if you do so | 13:44 |
| cedk | pokoli: I give this right based on trust but you are loosing all my trust with your behavior | 13:46 |
| pokoli | cedk: I think I already lost your trust some days ago. It will be great to talk about it | 13:49 |
| pokoli | Do you have time to talk about it now? If yes, please start explaining why you lost my trust | 13:50 |
| pokoli | cedk: I have some reviews I will like to push. Do you want to review them? | 14:10 |
| pokoli | https://foss.heptapod.net/tryton/tryton/-/merge_requests/660 | 14:10 |
| pokoli | https://foss.heptapod.net/tryton/tryton/-/merge_requests/653 | 14:10 |
| cedk | pokoli: I want to review all of them | 14:10 |
| pokoli | cedk: ok, so when I can expect that you will review them all? | 14:10 |
| cedk | pokoli: I do not know | 14:11 |
| pokoli | cedk: I must know because my customers are complaining because they are not fixed | 14:12 |
| cedk | pokoli: it is not my customer, I do review on my free time | 14:12 |
| pokoli | cedk: how much money do you want so I can get a review? | 14:14 |
| cedk | https://www.b2ck.com/tryton-services.html | 14:14 |
| pokoli | cedk: Can i just purchase a Basic suport service for reviewing? | 14:21 |
| pokoli | Does it include bug fixes? | 14:21 |
| cedk | pokoli: support is about fixing bug, so we provide a fix | 14:23 |
| pokoli | cedk: Understood thanks. I will consider such option | 14:23 |
| pokoli | cedk: but I can not buy something for somebody how does not trust me. So I think we will need to talk about trust before I can purchase something from B2CK | 14:23 |
| pokoli | cedk: at some point I guess you prefer to recover my trust than removing my publisher right. Am I right? | 14:28 |
| cedk | pokoli: of course | 14:33 |
| pokoli | cedk: same on my side. then better to talk about it no? | 14:38 |
| cedk | pokoli: turst is earned with acts | 14:40 |
| pokoli | cedk: to be honest I also missed some trust of you because I think that the contribution process is not equaly fair for everyone | 14:40 |
| pokoli | cedk: Could you make a list of acts that will allow me to recover your trust? TIA | 14:40 |
| cedk | pokoli: it never has been the goal | 14:47 |
| pokoli | cedk: then what is the goal? | 14:47 |
| cedk | pokoli: build a software with quality | 14:49 |
| pokoli | cedk: aja, so we have a review process to ensure quality right? | 15:08 |
| pokoli | cedk: To be honest I think our review process far for perfect and needs to improve a lot | 15:10 |
| pokoli | othewise I do not think we should have issues like https://foss.heptapod.net/tryton/tryton/-/issues/12419 which is just missing a field on a view | 15:10 |
| pokoli | and for me the main reason is because nobody is reviewing. Do you agree? | 15:11 |
| pokoli | I guess you already now it. But python project (which is by far bigger than ours). Just agreed to require review *just* for new features | 15:14 |
| pokoli | https://discuss.python.org/t/sc-poll-should-we-require-reviews-to-merge-all-prs/29410 | 15:14 |
| pokoli | Third reply is very interesting: https://discuss.python.org/t/sc-poll-should-we-require-reviews-to-merge-all-prs/29410/4 | 15:15 |
| cedk | pokoli: indeed we need to have such issue, you just pick an example where discussion was needed | 15:16 |
| cedk | pokoli: also issue are the history of the project, MR are just temporal chat | 15:16 |
| cedk | and you already raise such point (maybe not with Python project) but the answer is still the same, it is not by lowering the quality requested that the quality will stay or increase | 15:18 |
| pokoli | cedk: I never talked about changing the quality. I said: "Nobody is reviewing", which is a differnt issue | 15:21 |
| pokoli | cedk: follown the issue example. If we waited for the review process we will never had the feedback because the review will be stalled and the module never released | 15:23 |
| cedk | some poeple pledge to make reviews at the TUB2023 | 15:23 |
| pokoli | You already now: Most of people is just testing the code (and then raising issues) when it is released | 15:24 |
| pokoli | cedk: where are such people who pledged on the reviews? | 15:25 |
| cedk | pokoli: I do not understand the example of this issue, there was an issue with a suggestion to fix, I commented about the suggestion than you make a MR | 15:25 |
| cedk | pokoli: I do not want to point | 15:25 |
| pokoli | cedk: I do not need names. I'm pretty sure they won't come to make reviews | 15:27 |
| pokoli | cedk: I mean that which a good review process we will notice that the field was missing on the view and fixed before the release. | 15:28 |
| pokoli | So no issue will be created and the quality will be higher | 15:28 |
| cedk | pokoli: review process is not about finding bugs | 15:33 |
| cedk | of course it is better if some are found | 15:33 |
| pokoli | cedk: please say what is review process about instead of saying no... | 15:35 |
| pokoli | Otherwise I need to ask because I think my assumptions where completly wrong | 15:36 |
| cedk | pokoli: it is about quality, design, clarity | 15:36 |
| pokoli | cedk: also for reviews just adding a field? https://foss.heptapod.net/tryton/tryton/-/merge_requests/662/diffs#note_302958 | 15:37 |
| pokoli | also, I do not see where our "quality", "design" and "clarity" standards are written, except the ones that are related to code | 15:41 |
| pokoli | Main problem is that nobody can learn them so reviewers will fail to review because they do not know what to ask about | 15:41 |
| pokoli | Also developers do not know which is the expected result before starting their work | 15:42 |
| pokoli | by related to code I mean what is described here: https://www.tryton.org/develop/guidelines/code | 15:43 |
| pokoli | ACTION leaves for today | 16:24 |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 19:26 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 19:26 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!