IRC logs of #tryton for Friday, 2023-07-14

irc.libera.chat #tryton log beginning Fri Jul 14 12:10:01 AM CEST 2023
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton22:51
-!- ChanServ changed mode/#tryton -> +o cedk 22:51
-!- springwurm(~springwur@2a01:76c0:100:f500:5e89:2ee5:6d38:6030) has joined #tryton05:11
-!- mrichez(~Maxime@2a02:a03f:c2e8:f900:db7c:11fb:1fc6:3112) has joined #tryton06:06
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton06:10
-!- ChanServ changed mode/#tryton -> +o cedk 06:10
-!- rpit(~rpit@p200300c88f3a900073def768fc0dfae5.dip0.t-ipconnect.de) has joined #tryton06:26
-!- yangoon(~yangoon@pd9eedf81.dip0.t-ipconnect.de) has joined #tryton07:26
-!- rpit(~rpit@p200300c88f3a900073def768fc0dfae5.dip0.t-ipconnect.de) has joined #tryton08:29
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton08:56
-!- ChanServ changed mode/#tryton -> +o cedk 08:56
mrichezhi, we are using Supplier shipments for our stocks incoming moves (Purchases will be for the next of our migration). There's something strange when creating a new supplier shipment : i can set a planned date on the first move, then for other moves planned date is readonly09:45
mrichezanother question about supplier shipment : why when setting a planned date on the shipment , the planned date is not copied on the incoming moves as planned date ?09:53
mrichezfor the first question: planned become readonly on the move once you save the shipment. So i you create a new supplier shipment , you can set a planned date on the incoming moves until you save your shipment. 10:04
cedkmrichez: planned date can not be set on move when inside a shipment10:48
cedkmrichez: it is the planned date of the shipment that will be set10:49
cedkby _set_move_planned_date10:49
cedkmrichez: for the non readonly when shipment is created, I guess the states should also test _parent_shipment10:50
mrichezcedk: ok for the non readonly. But not sure the _set_move_planned_date is working. I just created a supplier shipment with a planned date in the demo 6.8, there an incoming move, but planned date of incoming move stay empty when saving11:07
mrichezcedk: incoming moves created have no planned date so test : (planned_date or datetime.date.max) < incoming_date is false and planned_date is not written on the move11:17
cedkmrichez: indeed I guess this should be only for move with origin11:18
cedkhttps://foss.heptapod.net/tryton/tryton/-/commit/fcc64f705f8311:20
cedkat least we need a way to distinct move created when filling shipment and move that have been created by other document like purchase11:22
mrichezcedk: ok... or if we are the only one concerned by this, i thought about a custo, but it seems difficult to update this code11:24
cedkthe change I pointed, did not take into account usage without purchase11:25
pokolicedk: but with purchase module the move planned date can be also empty, so it will have the same problem. 11:39
pokoliI just created a move on the demo using a purchase that does have an empty planned date: https://demo6.8.tryton.org/#demo6.8/model/stock.move/79711:40
cedkpokoli: no because if it is empty it is because it is computed like that11:40
pokoliAs there is a proposal to store the origin planned_date I'm not sure if testing is the latter is really usefull11:41
pokoliI mean: https://foss.heptapod.net/tryton/tryton/-/merge_requests/58411:42
cedkpokoli: do not unerstand11:43
pokoliI'm wondering if the commit you linked makes sense when the origin planned date is stored11:44
cedkpokoli: it does because it is unrelated11:44
pokoliThe user should be able to plan whenever they want, maybe the supplier told them that they will receive the full shipment two days before11:44
cedkpokoli: this is not prevented11:46
pokolicedk: then I do not understand what the linked commit does. Could you please explain it? 11:47
pokoliFor example: This shipment https://demo6.8.tryton.org/#demo6.8/model/stock.shipment.in/7 is linked to a move created to a purhcase, I set a planned date on the shipment and it is not replanned11:49
cedkit prevent to change the planned date if it is not for a later date11:50
pokolicedk: but it does not make sense to prevent that. Something may be planned for a 4 weeks in advance because the supplier initaly had this plan11:52
pokoliBut then can be replanned and received in just 3 weeks. So once the suppliers knows they tell you and you update such values in Tryton11:53
cedkpokoli: and this can be done11:53
pokolicedk: just see the linked shipment. It is not replanned :) 11:54
-!- springwurm(~springwur@2a01:76c0:100:f500:404:ffb9:f0ca:7671) has joined #tryton12:04
-!- cedk(~ced@gentoo/developer/cedk) has joined #tryton12:31
-!- ChanServ changed mode/#tryton -> +o cedk 12:31
mrichezanother question about Supplier Shipment, does it make sense to have an effective date in the future ? 13:19
cedkmrichez: not really except if you can predict the future13:21
mrichezcedk: :-), so it would make sense to prevent to set an effective_date > today ? one of our users made the error..  do i propose as a feature ?13:22
cedkmrichez: a warning about future (like for invoice) could be good14:20
mrichezcedk: ok14:24
-!- srgdts(~srgdts@user/srgdts) has joined #tryton20:16

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!