| irc.libera.chat #tryton log beginning Wed Dec 14 12:00:01 AM CET 2022 | ||
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 23:13 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 23:13 | |
| -!- OscarQ(~OscarQ@91.126.38.246) has joined #tryton | 06:30 | |
| -!- tbruyere(~Thunderbi@mail.saluc.com) has joined #tryton | 07:16 | |
| -!- mrichez(~Maxime@mail.saluc.com) has joined #tryton | 07:25 | |
| -!- rpit(~rpit@p200300c88f35d0008b509f4d786e7481.dip0.t-ipconnect.de) has joined #tryton | 08:05 | |
| -!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton | 08:15 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 08:24 | |
| -!- ChanServ changed mode/#tryton -> +o cedk | 08:24 | |
| -!- htgoebel(~hartmut@p200300d5df17e70021a42b9464239412.dip0.t-ipconnect.de) has joined #tryton | 08:45 | |
| htgoebel | Good mrning. | 08:45 |
|---|---|---|
| htgoebel | Great to hear heptapod migration is coming next weekend :-) | 08:45 |
| htgoebel | This will ease contributing for me a looooot. | 08:46 |
| htgoebel | Thaks to everybody working on this | 08:46 |
| pokoli | htgoebel: normally the most complex work is coding and not using the review tools. | 08:51 |
| -!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton | 08:52 | |
| htgoebel | pokoli: I know. Anyhow requireing a google account for rietveld as well as the custom tooling is hindering me | 09:00 |
| pokoli | htgoebel: but you can start coding now and then convert your patches to the mercurial format. | 09:07 |
| htgoebel | pokoli: :-) | 09:11 |
| pokoli | cedk: is there any convention for using for named branches of merge requests? It will be a good idea to use issueXXXX with the issue number? | 09:53 |
| cedk | pokoli: no and I do not think so | 10:05 |
| cedk | pokoli: if it is linked to an issue the commit message should have: Closes: #1234 | 10:06 |
| cedk | https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#default-closing-pattern | 10:06 |
| cedk | I expect people to use meaningful names | 10:07 |
| cedk | also many MR will no more be linked to an issue | 10:08 |
| cedk | see the website update | 10:10 |
| pokoli | cedk: ok, so we expect to fill directly Merge Requests and link them directly with the discuss? | 10:13 |
| cedk | and also topics name are ephemeral | 10:13 |
| cedk | pokoli: it is a possibility but I would put the discuss link in the MR comment, not the commit message | 10:14 |
| pokoli | that make sense | 10:15 |
| cedk | also for me committers will have to "clean" MR commits to follow our guidelines | 10:23 |
| pokoli | I guess we prefer to rebase all MR commits into a single one as we do now? | 10:26 |
| cedk | pokoli: I put it on the website | 10:30 |
| cedk | indeed I set for linear history but this does not mean to squash commits | 10:31 |
| cedk | indeed with evolve there is no reason to have MR with fix commits, commits should be amend | 10:31 |
| cedk | but sometimes you may want a MR with multiple step commits because it is easier to review and to follow | 10:31 |
| pokoli | cedk: Yes, I know there are multiple possiblities now, but the default behaviour should be just to amend right? | 10:35 |
| pokoli | otherwise we may ask on the review to include specific chanege as separate commit | 10:36 |
| pokoli | I agree that the best is to put it on website. I reviewed hegtapod and our guideliness to ensure everything is clear | 10:36 |
| cedk | pokoli: yes amend should be the default | 10:46 |
| -!- mrichez(~Maxime@2a02:a03f:c2e8:f900:db7c:11fb:1fc6:3112) has joined #tryton | 11:46 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton | 11:52 | |
| -!- acaubet1(~Thunderbi@194.224.31.235) has joined #tryton | 12:00 | |
| -!- acaubet(~Thunderbi@75.red-95-127-34.staticip.rima-tde.net) has joined #tryton | 12:02 | |
| -!- acaubet1(~Thunderbi@194.224.31.235) has joined #tryton | 12:39 | |
| -!- acaubet(~Thunderbi@194.224.31.235) has joined #tryton | 14:46 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:18c2:1aff:fef9:2b7f) has joined #tryton | 21:02 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!