| chat.freenode.net #tryton log beginning Fri 17 Apr 2020 12:00:01 AM CEST | ||
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 22:10 | |
| -!- k-man_(~jason@unaffiliated/k-man) has joined #tryton | 23:49 | |
| -!- giesen(~ggiesen@ego.giesen.me) has joined #tryton | 01:26 | |
| -!- thaneor(~ldlc6@r179-24-162-135.dialup.adsl.anteldata.net.uy) has joined #tryton | 01:50 | |
| -!- mrichez(~Maxime@2a02:a03f:4683:d700:47e0:27a8:4efc:f0fc) has joined #tryton | 05:48 | |
| -!- rpit(~rpit@p200300C88F4C2B0012585E561CBA5A6D.dip0.t-ipconnect.de) has joined #tryton | 06:30 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 07:24 | |
| -!- josesalvador(~josesalva@170.253.36.90) has joined #tryton | 07:28 | |
| -!- Timitos(~kpreisler@2001:a61:400:901:762b:62ff:fe84:ed7e) has joined #tryton | 07:42 | |
| -!- nicoe(~nicoe@2a02:578:852a:c00:7e2a:31ff:fe5e:b25d) has joined #tryton | 08:09 | |
| -!- giesen(~ggiesen@ego.giesen.me) has joined #tryton | 09:06 | |
| semarie | I just found that analytic lines has date set to move.post_date when analytic is set from rules. shouldn't be move.date instead ? | 09:16 |
|---|---|---|
| semarie | with that, I have expense from one fiscal year recorded in analytic in next fiscal year | 09:18 |
| -!- giesen(~ggiesen@ego.giesen.me) has joined #tryton | 09:21 | |
| cedk | semarie: I guess it was because the analytic lines are created when posting the move | 09:34 |
| cedk | but this sounds more logic to record analytic at the effective date of the move | 09:35 |
| semarie | cedk: the code explicitly use the post_date: entry.get_analytic_lines(line, line.move.post_date)) | 09:35 |
| semarie | I opened an issue | 09:36 |
| semarie | (in analytic_account, line.py file, line 239) | 09:36 |
| pokoli | semarie: for me it makes sense to use move.date, could you please submit a patch? ;) | 09:47 |
| semarie | pokoli: just done | 09:47 |
| semarie | https://bugs.tryton.org/issue9230 + https://codereview.tryton.org/305271002/ | 09:48 |
| pokoli | semarie: great. Thanks!! | 09:48 |
| -!- mariomop(~quassel@190.193.24.15) has joined #tryton | 10:54 | |
| -!- rpit(~rpit@p4FFB7828.dip0.t-ipconnect.de) has joined #tryton | 10:54 | |
| -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | 11:56 | |
| -!- thaneor1(~ldlc6@r190-134-6-138.dialup.adsl.anteldata.net.uy) has joined #tryton | 13:53 | |
| -!- josesalvador(~josesalva@170.253.36.90) has joined #tryton | 13:54 | |
| semarie | does it would make sens to have a button to re-apply rules on AnalyticLines ? | 15:12 |
| pokoli | semarie: do you think so? | 15:37 |
| pokoli | semarie: what will have changed in order to re-apply the rules? | 15:37 |
| semarie | pokoli: to be able to add rules after the fact, so MoveLine without AnalyticLines could have reconsidered | 15:39 |
| cedk | semarie: the rules are skipped as soon as the line has any analytic | 15:43 |
| cedk | also I do not think we should try to fill the history with analytic | 15:43 |
| semarie | yes. but what I want to do is to have a way to add analytic on already posted moves | 15:43 |
| semarie | *already posted moves, where there is no analytic | 15:44 |
| cedk | so with analytic state as draft? | 15:45 |
| cedk | I would say why not. | 15:46 |
| semarie | I am unsure to properly understand analytic state ... | 15:47 |
| semarie | it would be for lines waiting in the form "analytic lines to complete" | 15:47 |
| semarie | ACTION is unsure of the exact name in english language | 15:48 |
| semarie | yes, it is that "Analytic Lines to Complete" | 15:48 |
| cedk | yes | 15:49 |
| semarie | so according to the domain, it is for 'draft' state | 15:49 |
| pokoli | semarie: It will make sense to execute it from the list of analytic lines to complete | 15:52 |
| pokoli | semarie: which filters on analytic_state == 'draft' | 15:52 |
| semarie | thanks. I will take a look at it. the complex part for me will be to have a button on the ui | 15:54 |
| cedk | pokoli: will you commit https://codereview.tryton.org/46471002 even if you are no more assigned? | 15:54 |
| -!- josesalvador(~josesalva@170.253.36.90) has joined #tryton | 15:57 | |
| pokoli | cedk: yes, i will take care | 16:11 |
| -!- thaneor(~ldlc6@r190-134-6-138.dialup.adsl.anteldata.net.uy) has joined #tryton | 16:45 | |
| -!- thaneor1(~ldlc6@r186-55-16-182.dialup.adsl.anteldata.net.uy) has joined #tryton | 17:29 | |
| -!- k-man__(~jason@unaffiliated/k-man) has joined #tryton | 19:49 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!