| chat.freenode.net #tryton log beginning Wed Jul 26 00:00:01 CEST 2017 | ||
| 2017-07-26 00:08 <jcm> found an example: https://tryton-rietveld.appspot.com/2301002/diff/160001/trytond/modules/account_asset/invoice.py | ||
| 2017-07-26 00:32 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2017-07-26 01:02 -!- cedk_(~ced@host-85-201-184-151.dynamic.voo.be) has joined #tryton | ||
| 2017-07-26 01:19 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 02:20 -!- deep-book-gk_(~1wm_su@101-170.furanet.com) has joined #tryton | ||
| 2017-07-26 02:22 -!- deep-book-gk_(~1wm_su@101-170.furanet.com) has left #tryton | ||
| 2017-07-26 02:31 -!- kstenger(~karla@r167-56-236-118.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2017-07-26 03:04 -!- csotelo(~csotelo@2001:1388:49c6:15cb:faa8:b50e:157b:c616) has joined #tryton | ||
| 2017-07-26 03:41 -!- thaneor1(~ldlc6@r179-25-79-125.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2017-07-26 04:19 -!- jcm(~jcm@78.194.214.115) has joined #tryton | ||
| 2017-07-26 07:47 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton | ||
| 2017-07-26 08:06 -!- Xevi(~xevi@197.123.17.95.dynamic.jazztel.es) has joined #tryton | ||
| 2017-07-26 08:10 -!- JanGB(~jan@ipservice-092-208-133-033.092.208.pools.vodafone-ip.de) has joined #tryton | ||
| 2017-07-26 08:27 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2017-07-26 08:57 -!- rpit(~rpit@aftr-37-24-146-32.unity-media.net) has joined #tryton | ||
| 2017-07-26 09:16 -!- nicoe(~nicoe@host-85-201-184-151.dynamic.voo.be) has joined #tryton | ||
| 2017-07-26 10:19 <sim6> What IDE/editor and plugins are you using? | ||
| 2017-07-26 10:20 -!- JanGB(~jan@business-088-079-110-234.static.arcor-ip.net) has joined #tryton | ||
| 2017-07-26 10:21 <pokoli> sim6: I'm using vim | ||
| 2017-07-26 10:50 <sim6> pokoli: Please, could you share your configuration? | ||
| 2017-07-26 10:51 <pokoli> sim6: of course: https://github.com/pokoli/dotfiles/tree/master/.vim | ||
| 2017-07-26 10:51 <sim6> pokoli: thanks! | ||
| 2017-07-26 11:22 -!- semarie(~semarie@unaffiliated/semarie) has joined #tryton | ||
| 2017-07-26 11:27 -!- giesen(~ggiesen@2001:19f0:0:1019:5400:ff:fe25:bda6) has joined #tryton | ||
| 2017-07-26 11:33 -!- csotelo(~csotelo@2001:1388:49c6:15cb:faa8:b50e:157b:c616) has joined #tryton | ||
| 2017-07-26 12:07 -!- semarie(~semarie@unaffiliated/semarie) has joined #tryton | ||
| 2017-07-26 12:46 -!- semarie(~semarie@unaffiliated/semarie) has joined #tryton | ||
| 2017-07-26 12:56 -!- mariomop(~quassel@181.111.78.111) has joined #tryton | ||
| 2017-07-26 12:56 -!- JanGB(~jan@business-088-079-110-234.static.arcor-ip.net) has joined #tryton | ||
| 2017-07-26 13:07 -!- csotelo(~csotelo@2001:1388:49c7:2cc4:4ef8:959d:cd27:8685) has joined #tryton | ||
| 2017-07-26 13:23 -!- rpit(~rpit@aftr-37-24-146-32.unity-media.net) has joined #tryton | ||
| 2017-07-26 13:36 -!- orphean(~Orphean@31.192.224.224) has joined #tryton | ||
| 2017-07-26 13:49 -!- semarie(~semarie@unaffiliated/semarie) has joined #tryton | ||
| 2017-07-26 14:46 -!- smarro(~sebastian@181.16.7.104) has joined #tryton | ||
| 2017-07-26 16:14 -!- JanGB(~jan@x2f7f928.dyn.telefonica.de) has joined #tryton | ||
| 2017-07-26 16:18 -!- JanGB(~jan@business-088-079-110-234.static.arcor-ip.net) has joined #tryton | ||
| 2017-07-26 16:39 -!- JanGB(~jan@business-088-079-110-234.static.arcor-ip.net) has joined #tryton | ||
| 2017-07-26 16:42 -!- jmpoure(~jmpoure@63.109.206.77.rev.sfr.net) has joined #tryton | ||
| 2017-07-26 16:43 -!- jmpoure(~jmpoure@63.109.206.77.rev.sfr.net) has left #tryton | ||
| 2017-07-26 16:45 -!- kstenger(~karla@r167-56-252-38.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2017-07-26 17:05 -!- JanGB(~jan@ipservice-092-208-133-033.092.208.pools.vodafone-ip.de) has joined #tryton | ||
| 2017-07-26 17:22 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 17:37 -!- thaneor(~ldlc6@179.26.108.198) has joined #tryton | ||
| 2017-07-26 18:38 -!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton | ||
| 2017-07-26 20:48 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 20:54 <orphean> hg review doesn't work under python3 does it? | ||
| 2017-07-26 20:58 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 21:13 <cedk> orphean: I do not think but mercurial neither | ||
| 2017-07-26 21:14 <orphean> I was testing python 3.6 and yes you are right mercurial is also not working | ||
| 2017-07-26 21:14 <orphean> Ill just install it globally outside the venv | ||
| 2017-07-26 21:15 <orphean> mercurial is new to me | ||
| 2017-07-26 21:16 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 21:20 -!- nicoe(~nicoe@2a02:a03f:30b2:3c00:ee55:f9ff:fe7b:f7ac) has joined #tryton | ||
| 2017-07-26 21:26 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 21:27 <orphean> well seems its not working with 2.7 either | ||
| 2017-07-26 21:36 <cedk> orphean: can you elaborate | ||
| 2017-07-26 21:47 <orphean> yes sorry | ||
| 2017-07-26 21:48 <orphean> unknown exception encountered with possibly-broken third-party extension hgreview | ||
| 2017-07-26 21:49 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 21:49 <orphean> line 45 in mercurial.dispatch.run() AttributeError: 'function' has no attribute 'norepo' | ||
| 2017-07-26 21:51 <cedk> orphean: I do not think it is linked to hgreview | ||
| 2017-07-26 21:52 <orphean> I installed mercurial with dnf and hgreview with pip2 system wide | ||
| 2017-07-26 21:53 <orphean> ill uninstall mercurial with dnf and reinstall with pip2 then see | ||
| 2017-07-26 22:01 -!- semarie(~semarie@unaffiliated/semarie) has joined #tryton | ||
| 2017-07-26 22:01 <orphean> do i need to make repository specific updates to hgrc in ./.hg/hgrc or create new file ./.hgrc? | ||
| 2017-07-26 22:19 <orphean> ok i had to force mercurial back to version 3.2 to get hgreview to work | ||
| 2017-07-26 22:20 <orphean> does not work with latest version even on python 2.7 | ||
| 2017-07-26 22:25 <orphean> ced you still there? I cloned the repo, submitted a new issue https://bugs.tryton.org/issue6677, made changes to files in repo, now i want to submit it | ||
| 2017-07-26 22:26 <orphean> i tried "hg review -i 6677" but it claims that no issue exists with that id | ||
| 2017-07-26 22:29 <kstenger> orphean: it seems you have an older version of hgreview, I'm sure the latest will solve your problem with latest mercurial version https://bitbucket.org/nicoe/hgreview | ||
| 2017-07-26 22:29 <kstenger> orphean: the issue number you give hg review is the id of the review, which should be empty when it does not exist | ||
| 2017-07-26 22:29 <orphean> no i have the latest version 0.4 | ||
| 2017-07-26 22:29 <orphean> i still had to downgrade mercurial | ||
| 2017-07-26 22:30 <kstenger> orphean: clone it and install it from source | ||
| 2017-07-26 22:30 <orphean> ok, so how do i link a review to the id on this issue tracker? | ||
| 2017-07-26 22:33 <orphean> i literally append "(issueNNNN)" to the end of the message? | ||
| 2017-07-26 22:34 <kstenger> the id of the issue should go in the message, as explained http://www.tryton.org/how-to-contribute.html in the Submitting codereview section | ||
| 2017-07-26 22:34 <kstenger> yes | ||
| 2017-07-26 22:34 <orphean> sorry if it's a stupid question but i don't want to mess up your issue/review system | ||
| 2017-07-26 22:34 <kstenger> orphean: not stupid if it's your first time | ||
| 2017-07-26 22:36 <orphean> so if would "trytond: Allow serving of configurable file directly from root URL in Werkzeug dispatcher (issue6677)" be acceptable? | ||
| 2017-07-26 22:37 <kstenger> orphean: no, the issue should go on a separate line, it's better to first create the file and then pass it by parameter with -l | ||
| 2017-07-26 22:38 <kstenger> orphean: also, no parens | ||
| 2017-07-26 22:41 <kstenger> orphean: also, while it's on review it's editable from the web | ||
| 2017-07-26 22:41 -!- orphean_(~Orphean@31.192.224.224) has joined #tryton | ||
| 2017-07-26 22:44 <orphean_> -l is for hg commit no? not hg review? | ||
| 2017-07-26 22:45 <kstenger> orphean_: both | ||
| 2017-07-26 22:47 <orphean_> hg review is telling me the option -l is not recognised | ||
| 2017-07-26 22:47 <kstenger> orphean_: the file is reusable if you have commit rights, adding the review id and removing the "trytond: " prefix to the commit message, so the format is the same | ||
| 2017-07-26 22:48 <orphean_> im not trying to commit, i have no commit rights, just submit for review | ||
| 2017-07-26 22:48 <kstenger> yeah, just explaining that 'ts the same format for the file | ||
| 2017-07-26 22:49 <kstenger> I don't know why you have that error for the -l parameter | ||
| 2017-07-26 22:51 <kstenger> orphean_: are you putting -l before "review" ? it should be "hg review -l filename" | ||
| 2017-07-26 22:52 <orphean_> yea i am writing it correctly, im checking the hg review files i have installed now | ||
| 2017-07-26 22:53 <kstenger> orphean_: I recomend you install the hgreview from source, you will be able to get back to a newer hg version | ||
| 2017-07-26 22:53 <orphean_> yea pip is lying | ||
| 2017-07-26 22:54 <kstenger> orphean_: it | ||
| 2017-07-26 22:54 <orphean_> it says its 0.4 but it's quite evdently not when i look at __init__.py | ||
| 2017-07-26 22:54 <kstenger> it's not yet released | ||
| 2017-07-26 22:54 <kstenger> oh ok | ||
| 2017-07-26 22:56 <orphean_> so do you have a naming convention or recommended storage path for the issue message files you pass to -l? | ||
| 2017-07-26 22:56 <orphean_> just out of interest | ||
| 2017-07-26 22:57 <kstenger> it doesn't matter as it's uploaded as a commit message, not as a file per se | ||
| 2017-07-26 22:58 <kstenger> just *don't* "hg add" it | ||
| 2017-07-26 23:01 <orphean_> can you explain a bit further what you mean by keeping the same file but removing the trytond: prefix? | ||
| 2017-07-26 23:04 <kstenger> orphean_: don't worry if you don't have commit rights someone else will do it for you, if you ever get rights, the title of review should say "tryton: ...", "trytond: ..." or whatever module you are modifying, but when you commit, this part of the title should not go | ||
| 2017-07-26 23:05 <kstenger> (just reminding it to myself :p) | ||
| 2017-07-26 23:05 <orphean_> i see | ||
| 2017-07-26 23:06 <orphean_> its also now asking me for a "message describing this patch set" even though ive passed the message in with -l successfully | ||
| 2017-07-26 23:06 <orphean_> and its not happy if i leave it blank | ||
| 2017-07-26 23:06 <kstenger> orphean_: are you rinning it a second time? | ||
| 2017-07-26 23:06 <kstenger> running* | ||
| 2017-07-26 23:06 <orphean_> i dont know at this stage : D | ||
| 2017-07-26 23:07 <kstenger> check "hg review --id" | ||
| 2017-07-26 23:07 <kstenger> if you get a number, then you have already uploaded it | ||
| 2017-07-26 23:07 <orphean_> 6677 | ||
| 2017-07-26 23:07 <orphean_> hm | ||
| 2017-07-26 23:07 <kstenger> ah, you messed it before, so use "hg review --clean" | ||
| 2017-07-26 23:08 <orphean_> thx it seemed to work | ||
| 2017-07-26 23:08 <orphean_> \o/ | ||
| 2017-07-26 23:08 <kstenger> :D | ||
| 2017-07-26 23:09 <kstenger> orphean_: if you have to re-upload the review, next time just use -m with an apropriate description just for this change | ||
| 2017-07-26 23:10 <kstenger> so don't use the file you passed with -l | ||
| 2017-07-26 23:10 <orphean_> ok and i can swap between existing reviews with -i right? | ||
| 2017-07-26 23:10 <kstenger> no | ||
| 2017-07-26 23:11 <kstenger> just clone it in paralell and use for another issue | ||
| 2017-07-26 23:16 <orphean_> i still have a lot to learn about mercurial but do you mean clone the entire repo for each fix to its own directory rather than using any of mercurials branch features | ||
| 2017-07-26 23:18 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 23:18 <kstenger> orphean_: yes, this is what I mean, branches are for something else | ||
| 2017-07-26 23:19 <kstenger> once your fix is committed you can clean the review number, pull, update and re-use the directory | ||
| 2017-07-26 23:23 <orphean_> ok cool | ||
| 2017-07-26 23:24 <orphean_> while you're here do you know anything about how to get the windows 4.4 installable exe client to output debug | ||
| 2017-07-26 23:24 <orphean_> since the beginning it has been unable to connect to my server when I enable ssl | ||
| 2017-07-26 23:25 <kstenger> no, I don't know this | ||
| 2017-07-26 23:25 <orphean_> which im tearing my hair out trying to understand as i can connect over ssl fine and even call e.g. the database listing api with custom test code | ||
| 2017-07-26 23:26 <orphean_> but cant get any logs out of the failing client | ||
| 2017-07-26 23:28 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 23:32 <orphean_> anyway, thanks a lot for your patience and help with the code review submission | ||
| 2017-07-26 23:33 <kstenger> orphean_: yw I like it when there is something I can help with heh, it seems something went wrong with your upload, the review is not well shown, I wonder if you should re-upload | ||
| 2017-07-26 23:35 <kstenger> it complains "Can't parse the patch to chunks" when trying to see the side by side diff | ||
| 2017-07-26 23:36 <orphean_> ok so how do i re-upload? | ||
| 2017-07-26 23:37 <orphean_> the review bot has also noticed that redirect import is now unused | ||
| 2017-07-26 23:37 <orphean_> which i neglected to remove | ||
| 2017-07-26 23:39 <kstenger> try just "hg review -m 'Re-upload" | ||
| 2017-07-26 23:39 <kstenger> I missed a ' there | ||
| 2017-07-26 23:42 <orphean_> yea it also seems my first message wasn't included in the first upload | ||
| 2017-07-26 23:43 <kstenger> it seems correct "trytond: Allow serving of configurable file directly from root URL in Werkzeug dispatcher" | ||
| 2017-07-26 23:44 <orphean_> oh right yes but in the messages list it appears blank | ||
| 2017-07-26 23:44 <orphean_> thats where i was looking | ||
| 2017-07-26 23:44 <kstenger> it's because the first time it puts it as a title | ||
| 2017-07-26 23:44 <kstenger> after patch set 1, the rest have sub-titles | ||
| 2017-07-26 23:45 <orphean_> regardless it's still saying Can't parse the patch to chunks right? | ||
| 2017-07-26 23:45 -!- JosDzG(~Thunderbi@189.250.108.243) has joined #tryton | ||
| 2017-07-26 23:45 <kstenger> yeah, I have no clue why this happens | ||
| 2017-07-26 23:46 <orphean_> is it only me? | ||
| 2017-07-26 23:46 <kstenger> orphean_: (unrelated) maybe the title is a bit too long | ||
| 2017-07-26 23:49 <cedk> orphean_: it happens sometimes, I think it maybe related to older version of review module | ||
| 2017-07-26 23:50 <orphean_> i installed hg review from source this time | ||
| 2017-07-26 23:51 <kstenger> orphean_: did you also upgrade mercurial? | ||
| 2017-07-26 23:51 <orphean_> 4.2.2 on python 2.7 | ||
| 2017-07-26 23:52 <kstenger> orphean_: also, did you ensure hgreview was uninstalled before reinstalling from source? | ||
| 2017-07-26 23:52 <orphean_> yes | ||
| 2017-07-26 23:52 <orphean_> i can nuke my whole python 2.7 install and try again | ||
| 2017-07-26 23:59 <kstenger> I guess it's always a good start to have a clean install (thanks virtualenv for that) |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!