IRC logs of #tryton for Friday, 2016-11-11

chat.freenode.net #tryton log beginning Fri Nov 11 00:00:01 CET 2016
2016-11-11 00:35 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton
2016-11-11 01:17 -!- nramirezuy(~nramirezu@r167-62-186-30.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 01:54 -!- nramirezuy(~nramirezu@r167-62-204-135.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 02:06 -!- apostatize(~visavis@unaffiliated/apostatize) has joined #tryton
2016-11-11 02:31 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton
2016-11-11 03:16 -!- smarro(~sebastian@181.16.7.104) has joined #tryton
2016-11-11 03:18 -!- perilla(~perilla@191.100.15.78) has joined #tryton
2016-11-11 04:32 -!- kstenger1(~karla@r186-54-186-51.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 07:47 -!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton
2016-11-11 08:41 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton
2016-11-11 09:33 -!- udono(~udono@tmo-112-227.customers.d1-online.com) has joined #tryton
2016-11-11 09:35 -!- rpit(~rpit@aftr-37-24-151-103.unity-media.net) has joined #tryton
2016-11-11 10:05 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton
2016-11-11 10:37 <pokoli> should tax_identifier set on _check_modify_excluded field?
2016-11-11 10:38 <pokoli> Let me explaing what I found: I have a paid invoice created after the tax_identifier field was added, so if I unreconcile it's lines I get and error that I can not modify it's lines because the post, calls the set_number, which's sets the tax identifier for the invoice and then raises the error
2016-11-11 10:39 <pokoli> The other solution is to fill the tax_identifier on migration for posted invoices
2016-11-11 10:42 <pokoli> everything goes well on new created invoices as the tax_identifier is set on posting
2016-11-11 10:58 <pokoli> Indeed, the error is raised if the company has no tax_identifier set, as it tries to write the None value to the paid invoice when setting number
2016-11-11 11:06 -!- csotelo(~csotelo@190.238.132.117) has joined #tryton
2016-11-11 11:07 -!- thaneor(~ldlc6@179.26.17.183) has joined #tryton
2016-11-11 11:28 <cedk> pokoli: indeed we should separate tax identifier from set_number
2016-11-11 11:32 <cedk> pokoli: or better to not set a tax identifier if the state is already posted
2016-11-11 11:33 <cedk> pokoli: but as number is neither in _check_modify_excluded, number should also be skiped
2016-11-11 11:35 -!- smarro(~sebastian@181.16.7.104) has joined #tryton
2016-11-11 11:38 <pokoli> cedk: I think it's better to not modify number nor tax_identifier if invoice is not in draft state, what do you think?
2016-11-11 11:38 <cedk> pokoli: no because it is also about validated
2016-11-11 11:39 <cedk> pokoli: so only the posted, paid state should be skipped
2016-11-11 11:39 <cedk> pokoli: just like check_modify does
2016-11-11 11:40 <pokoli> cedk: ok, I'm creating and issue + codereview
2016-11-11 12:13 -!- mariomop(~quassel@181.110.216.131) has joined #tryton
2016-11-11 12:44 -!- rajeevn(~rajeevn@unaffiliated/rajeevn) has joined #tryton
2016-11-11 13:41 -!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton
2016-11-11 14:10 -!- lukio(~lukio@191.85.185.103) has joined #tryton
2016-11-11 14:12 -!- smarro(~sebastian@181.16.7.104) has joined #tryton
2016-11-11 14:14 -!- udono(~udono@ip-178-202-243-21.hsi09.unitymediagroup.de) has joined #tryton
2016-11-11 14:27 -!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton
2016-11-11 14:35 -!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton
2016-11-11 14:42 -!- lukio(~lukio@191.85.185.103) has left #tryton
2016-11-11 15:28 -!- andrespoliti(~andrespol@250-183-89-200.fibertel.com.ar) has joined #tryton
2016-11-11 15:28 <andrespoliti> hi, we are making an extension to party that changes the type of a one2many field to a many2many by redefining it, but it doesn't work. If we change the type of the field in the original party module, it works. Is this a bug or do we have to do it another way?
2016-11-11 15:28 -!- kstenger(~karla@r186-54-186-51.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 15:29 <cedk> andrespoliti: it is not supported to change the type of a field
2016-11-11 15:31 <cedk> andrespoliti: also it will break any other modules that use this field
2016-11-11 15:36 <pokoli> andrespoliti: why you don't add a new field? and change the views?
2016-11-11 15:37 <andrespoliti> because it's the addresses field, which is used by other modules
2016-11-11 15:38 <pokoli> andrespoliti: wow. Could you explain the rational of this change?
2016-11-11 15:39 <pokoli> andrespoliti: AFAIU if you need the same address for diferent parties, you should duplicate it. So if the party moves to another place, only the address of one party is updated
2016-11-11 15:43 <andrespoliti> yes, it's true, but we have to adapt to an external system that is modeled that way
2016-11-11 15:44 <cedk> andrespoliti: make the adaption outside the system
2016-11-11 15:45 -!- pollex(~pollex@250-183-89-200.fibertel.com.ar) has joined #tryton
2016-11-11 15:46 -!- andrespoliti(~andrespol@250-183-89-200.fibertel.com.ar) has joined #tryton
2016-11-11 16:33 -!- kstenger1(~karla@r186-55-77-202.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 16:52 -!- nramirezuy(~nramirezu@r167-62-6-202.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 17:04 -!- afibanez(~afibanez@170.red-80-28-119.adsl.static.ccgg.telefonica.net) has joined #tryton
2016-11-11 17:19 -!- rpit(~rpit@2a02:908:e672:1520:56ee:75ff:fe0d:d3c7) has joined #tryton
2016-11-11 17:20 -!- JosDzG(~Thunderbi@fixed-188-72-187-188-72-36.iusacell.net) has joined #tryton
2016-11-11 17:29 -!- rpit(~rpit@2a02:908:e672:1520:56ee:75ff:fe0d:d3c7) has joined #tryton
2016-11-11 18:10 -!- lukio(~lukio@181.45.71.170) has joined #tryton
2016-11-11 18:21 -!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has left #tryton
2016-11-11 18:21 -!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton
2016-11-11 20:53 -!- csotelo(~csotelo@2001:1388:49c5:308c:5644:1d95:dec5:ca75) has joined #tryton
2016-11-11 21:32 -!- thaneor(~ldlc6@r179-25-53-47.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 21:39 -!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton
2016-11-11 21:43 -!- perilla(~perilla@corp-190-57-169-210.cue.puntonet.ec) has left #tryton
2016-11-11 22:04 -!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has joined #tryton
2016-11-11 22:09 -!- perilla1(~perilla@corp-190-57-169-210.cue.puntonet.ec) has left #tryton
2016-11-11 23:01 -!- thaneor(~ldlc6@r179-25-53-47.dialup.adsl.anteldata.net.uy) has joined #tryton
2016-11-11 23:04 -!- udono(~udono@ip-178-202-243-21.hsi09.unitymediagroup.de) has joined #tryton

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!