| chat.freenode.net #tryton log beginning Tue Aug 23 00:00:01 CEST 2016 | ||
| 2016-08-23 00:13 <shrox> cedk: I'm not doing the final gsoc evaluation right now, but when I do, do I link it to rietveld where I've uploaded the patches? | ||
| 2016-08-23 03:24 -!- meigallodixital_(~meigallod@188.72.113.41) has joined #tryton | ||
| 2016-08-23 03:35 -!- JosDzG(~Thunderbi@189.188.58.194) has joined #tryton | ||
| 2016-08-23 05:15 -!- nramirezuy(~nramirezu@r167-62-111-58.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-08-23 07:29 -!- prayashm(~prayashm@45.251.36.68) has joined #tryton | ||
| 2016-08-23 07:29 -!- prayashm(~prayashm@unaffiliated/prayashm) has joined #tryton | ||
| 2016-08-23 07:51 -!- rpit(~rpit@aftr-37-24-145-212.unity-media.net) has joined #tryton | ||
| 2016-08-23 08:36 -!- gytis(~gytis@v100.nfq.lt) has joined #tryton | ||
| 2016-08-23 08:36 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2016-08-23 08:54 -!- mrichez(~smuxi@mail.saluc.com) has joined #tryton | ||
| 2016-08-23 09:24 -!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton | ||
| 2016-08-23 09:40 <cedk> shrox: yes or of your github repo | ||
| 2016-08-23 09:46 -!- udono(~udono@ip-37-201-245-214.hsi13.unitymediagroup.de) has joined #tryton | ||
| 2016-08-23 10:14 -!- nicoe(~nicoe@2001:6f8:3aa:2:ee55:f9ff:fe7b:f7ac) has joined #tryton | ||
| 2016-08-23 10:17 <prayashm> cedk: What is a customizator? | ||
| 2016-08-23 10:19 <cedk> prayashm: I mean people who will customize Tryton | ||
| 2016-08-23 10:20 <cedk> prayashm: we expect that people will use at least a custom css on sao to make it fits with company theme | ||
| 2016-08-23 10:20 <cedk> prayashm: that's why we want to have only strictly needed CSS rules | ||
| 2016-08-23 10:20 <prayashm> cedk: I get it. Thanks! | ||
| 2016-08-23 10:23 <cedk> prayashm: by the way, about the expand of the fields when using auto-detect | ||
| 2016-08-23 10:23 <cedk> prayashm: I think it will be good to try to fix it any way | ||
| 2016-08-23 10:23 <prayashm> cedk: That's fixed | ||
| 2016-08-23 10:24 <prayashm> cedk: I am just removing the css and pushing the patch | ||
| 2016-08-23 10:24 <cedk> prayashm: I mean that it expands the tree | ||
| 2016-08-23 10:24 <prayashm> cedk: Yes. It doesn't do that now. | ||
| 2016-08-23 10:24 <cedk> prayashm: I think you could have an extra paramter that says to collapse the node after expanding it | ||
| 2016-08-23 10:24 <prayashm> cedk: I did that exact thing :D | ||
| 2016-08-23 10:24 <cedk> prayashm: ha OK, how did you fix that? | ||
| 2016-08-23 10:25 <cedk> prayashm: OK good | ||
| 2016-08-23 10:25 <prayashm> cedk: Just kept note of the element at the highest level that is being expanded, and just collapsing that after everything is done | ||
| 2016-08-23 10:28 <cedk> prayashm: I will check the code | ||
| 2016-08-23 10:51 <prayashm> Is there a way to delete the last patch from codereview? | ||
| 2016-08-23 10:51 <cedk> prayashm: there is a delete button | ||
| 2016-08-23 10:53 <prayashm> cedk: Oh yes. Thanks! | ||
| 2016-08-23 10:58 <prayashm> cedk: about the missing scrollbar, which browser are you using? | ||
| 2016-08-23 11:09 <cedk> prayashm: firefox | ||
| 2016-08-23 11:09 <cedk> prayashm: I tested in mobile mode but I have to re-check | ||
| 2016-08-23 13:01 -!- prayashm(~prayashm@unaffiliated/prayashm) has joined #tryton | ||
| 2016-08-23 13:08 -!- mariomop(~quassel@181.111.66.56) has joined #tryton | ||
| 2016-08-23 13:29 -!- prayashm(~prayashm@unaffiliated/prayashm) has joined #tryton | ||
| 2016-08-23 15:09 <shrox> cedk: To generalize for all FOD files, I need to save the mimetype initially in a global variable. Would that be okay to do? | ||
| 2016-08-23 15:13 <cedk> shrox: global variable is always bad | ||
| 2016-08-23 15:13 <cedk> shrox: it will prevent to use the lib in parallel | ||
| 2016-08-23 15:16 <shrox> cedk: I know. But the thing is that to figure out the required mimetype of the file to add to the manifest is becoming difficult. I already do it once when I create the mimetype file, but the second time around I have lost access to the file name which prevents me from recognizing the kind of file. Do you understand the problem here? | ||
| 2016-08-23 15:17 <cedk> shrox: it should not be a problem if you had a good abstraction design | ||
| 2016-08-23 15:20 <shrox> cedk: I think I have got this without a global variable. Let me have a look. | ||
| 2016-08-23 15:28 <shrox> cedk: In __main__, when I write file object to system, currently I am renaming to file by default to xyz.odt | ||
| 2016-08-23 15:29 <shrox> cedk: Which is obviously something that I do not want to do | ||
| 2016-08-23 15:29 <shrox> cedk: I will have to create a function to rename the fod to equivalent od, I think | ||
| 2016-08-23 15:29 <shrox> cedk: So is it okay to write this function within __main__ itself? | ||
| 2016-08-23 15:38 <cedk> shrox: why not just ask the user to pass the name? | ||
| 2016-08-23 15:39 <cedk> shrox: explicit is better than implicit | ||
| 2016-08-23 15:40 <shrox> cedk: that'll simplify it for me as well, haha. Sure, I'll do that. | ||
| 2016-08-23 16:43 <shrox> cedk: Hey, can you reply to the review comment about the zip_file, please? | ||
| 2016-08-23 17:18 -!- nicoe(~nicoe@balisto.wifi.b2ck.com) has joined #tryton | ||
| 2016-08-23 17:20 -!- nramirezuy(~nramirezu@r167-62-63-200.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-08-23 17:43 -!- JosDzG(~Thunderbi@fixed-188-72-187-188-72-36.iusacell.net) has joined #tryton | ||
| 2016-08-23 18:32 -!- scrapper(~scrapper@88.117.159.6) has joined #tryton | ||
| 2016-08-23 18:32 <cedk> pokoli: did you tested the GooCalendar and issue5786 ? | ||
| 2016-08-23 19:12 -!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton | ||
| 2016-08-23 19:13 -!- scrapper(~scrapper@88.117.159.6) has joined #tryton | ||
| 2016-08-23 19:57 -!- scrapper(~scrapper@88.117.159.6) has joined #tryton | ||
| 2016-08-23 20:41 -!- shrox(shrox@nat/iiit/x-lbjcmujxwteijued) has joined #tryton | ||
| 2016-08-23 21:58 -!- mariomop(~quassel@181.95.244.250) has joined #tryton | ||
| 2016-08-23 22:55 -!- shrox(shrox@nat/iiit/x-ufgycmqrdhffxmal) has joined #tryton | ||
| 2016-08-23 22:57 -!- shrox(shrox@nat/iiit/x-cfopmbxkpemsulos) has joined #tryton |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!