| chat.freenode.net #tryton log beginning Thu Jul 7 00:00:02 CEST 2016 | ||
| 2016-07-07 00:35 -!- zmijunkie1(~Adium@i59F5DA3A.versanet.de) has joined #tryton | ||
| 2016-07-07 01:02 -!- JosDzG(~Thunderbi@fixed-188-72-187-188-72-36.iusacell.net) has joined #tryton | ||
| 2016-07-07 08:19 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton | ||
| 2016-07-07 08:29 -!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton | ||
| 2016-07-07 08:33 -!- aasnan(~angel@48.red-83-45-194.dynamicip.rima-tde.net) has joined #tryton | ||
| 2016-07-07 08:41 -!- zmijunkie(~Adium@176.0.136.164) has joined #tryton | ||
| 2016-07-07 08:57 -!- mrichez(~smuxi@mail.saluc.com) has joined #tryton | ||
| 2016-07-07 09:02 -!- zmijunkie(~Adium@b2b-78-94-52-226.unitymedia.biz) has joined #tryton | ||
| 2016-07-07 09:15 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2016-07-07 09:16 -!- yangoon_rm(~mathiasb@137.158.23.210) has joined #tryton | ||
| 2016-07-07 09:39 -!- udono(~udono@tmo-098-146.customers.d1-online.com) has joined #tryton | ||
| 2016-07-07 10:09 -!- yangoon_rm(~mathiasb@137.158.23.210) has joined #tryton | ||
| 2016-07-07 10:11 -!- nicoe(~nicoe@balisto.wifi.b2ck.com) has joined #tryton | ||
| 2016-07-07 10:52 -!- zmijunkie1(~Adium@b2b-78-94-52-226.unitymedia.biz) has joined #tryton | ||
| 2016-07-07 11:23 -!- meigallodixital(~meigallod@188.72.113.6) has joined #tryton | ||
| 2016-07-07 11:34 -!- yangoon_rm(~mathiasb@137.158.23.210) has joined #tryton | ||
| 2016-07-07 12:09 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton | ||
| 2016-07-07 12:54 -!- mariomop(~quassel@181.92.6.139) has joined #tryton | ||
| 2016-07-07 15:01 -!- shrox(shrox@nat/iiit/x-sqhigtwzywgsxknd) has joined #tryton | ||
| 2016-07-07 15:04 -!- yangoon_rm(~mathiasb@137.158.23.210) has joined #tryton | ||
| 2016-07-07 15:06 -!- shrox(shrox@nat/iiit/x-lzpaikpedzoslcbq) has joined #tryton | ||
| 2016-07-07 16:22 -!- kstenger(~karla@r186-50-16-37.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-07-07 16:24 -!- JosDzG(~Thunderbi@fixed-188-72-187-188-72-36.iusacell.net) has joined #tryton | ||
| 2016-07-07 16:24 -!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton | ||
| 2016-07-07 16:32 -!- paco__(4f90f0a5@gateway/web/freenode/ip.79.144.240.165) has joined #tryton | ||
| 2016-07-07 16:32 <paco__> hi all! do you know if there is a modulo to manage loans in tryton? | ||
| 2016-07-07 16:36 <cedk> paco__: from which point of view? | ||
| 2016-07-07 16:37 <paco__> from the point of view that it has regular payments, (more or less like an amortization), wich could be automated in some cases (fixed interest rates)... | ||
| 2016-07-07 16:44 <cedk> paco__: what is the advantage to compute it instead of entering it? | ||
| 2016-07-07 16:46 <paco__> well it could update itself (the total pending value of amortization) instead of having to enter the amortization and interest payment every month... | ||
| 2016-07-07 16:49 <cedk> paco__: why are you talking about amortization? | ||
| 2016-07-07 16:51 <paco__> sorry, i might be expressing myself poorly,i am talking about loan amortization... it is the payment of the loan itself, not interests. | ||
| 2016-07-07 16:52 <paco__> but i was just checking if there was a module related to loans... | ||
| 2016-07-07 16:54 -!- mariomop(~quassel@181.92.6.68) has joined #tryton | ||
| 2016-07-07 17:07 <shrox> cedk: I've changed most of the things you asked me in the comments. Should I go ahead now with changing the way images are handled (that is, by reading the content.xml file again?) | ||
| 2016-07-07 17:07 <shrox> cedk: Also, you had also mentioned that perhaps images could also be in the styles.xml file. I couldn't find any information about this online though. | ||
| 2016-07-07 17:08 <cedk> shrox: try to put an image in the header/footer | ||
| 2016-07-07 17:13 <shrox> cedk: Okay, it's there. How do you suggest I work on this? | ||
| 2016-07-07 17:17 <cedk> shrox: what do you propose? | ||
| 2016-07-07 17:18 <cedk> shrox: by the way, I still don't understand why you have a class? | ||
| 2016-07-07 17:18 <cedk> shrox: instanciate a class and just call a method on it is just useless | ||
| 2016-07-07 17:21 <shrox> cedk: class FODT2ODT? It slipped me again. Sorry. | ||
| 2016-07-07 17:24 <shrox> cedk: For the images, I was just thinking of making another function for the body tag in content. But now that I see that there is the styles tag to take care of as well. I can make a function that will handle images and call it for styles and body. | ||
| 2016-07-07 17:25 <cedk> shrox: I don't know | ||
| 2016-07-07 17:25 <cedk> shrox: for now, I find the structure of your code very unclear | ||
| 2016-07-07 17:25 <shrox> cedk: The class I thought would be necessary when importing. But I can of course just use a function. | ||
| 2016-07-07 17:25 <cedk> shrox: I think it is the first thing to do is to have a clean design | ||
| 2016-07-07 17:26 <shrox> cedk: Okay. Which part/s? | ||
| 2016-07-07 17:37 <cedk> shrox: the all | ||
| 2016-07-07 17:38 <shrox> cedk: Can you explain? | ||
| 2016-07-07 17:39 <cedk> shrox: one of the most important think when written software is to have a clean structure of the code to make it easier for others to understand it | ||
| 2016-07-07 17:39 <cedk> shrox: you write code to be read by others | ||
| 2016-07-07 17:40 <cedk> shrox: for now, when I read your code, it is very difficult to understand | ||
| 2016-07-07 17:41 <cedk> shrox: for example, the split_file method | ||
| 2016-07-07 17:41 <cedk> it is complicated to understand what is going on | ||
| 2016-07-07 17:42 <cedk> with such name, I would expect to pass a file and to receive a list of splitted files | ||
| 2016-07-07 17:43 <cedk> but indeed the method write into a zip file a dump of a tree etc. | ||
| 2016-07-07 17:44 <cedk> shrox: you should try to define a simple flow which will be cut into methods etc. | ||
| 2016-07-07 17:44 <cedk> shrox: also don't try to do too much in one method | ||
| 2016-07-07 17:44 <cedk> and also put docstring that explain what does the method | ||
| 2016-07-07 17:45 <cedk> usually just trying to document, show you design issue | ||
| 2016-07-07 17:46 <cedk> shrox: do you see my point? | ||
| 2016-07-07 17:47 <shrox> cedk: Okay. Got it. I will try to make it simpler to understand. | ||
| 2016-07-07 17:48 <shrox> cedk: Any specifics that you think I should especially change? | ||
| 2016-07-07 17:48 <cedk> shrox: so key point: method doing simple thing that you can easy explain in the docstring | ||
| 2016-07-07 17:48 <cedk> shrox: but be careful to be not too simple (like 1 line of code) | ||
| 2016-07-07 17:49 <shrox> cedk: Sure | ||
| 2016-07-07 17:49 <cedk> shrox: also try to minimize the number of argument of methods, it is often sign that it is too complex | ||
| 2016-07-07 17:50 <cedk> shrox: so for odf2od, I think the zip management should be separated | ||
| 2016-07-07 17:50 <cedk> shrox: you probably need to store the tree instances in a dict | ||
| 2016-07-07 17:50 <cedk> shrox: and have an last method that take the dict and dump in a zipfile | ||
| 2016-07-07 17:53 -!- zmijunkie(~Adium@i59F5DA3A.versanet.de) has joined #tryton | ||
| 2016-07-07 17:54 <shrox> cedk: I didn't understand. Are you saying I should store"fodt_root", "fodt_namespaces", etc. in a dictionary and pass that in the methods? | ||
| 2016-07-07 17:58 <cedk> shrox: don't know what is fodt_root | ||
| 2016-07-07 18:00 <shrox> cedk: It's just what i get after getroot() on the tree | ||
| 2016-07-07 18:04 <shrox> cedk: see the parse_fodt method | ||
| 2016-07-07 18:04 <cedk> shrox: if we take tha split method, for me it should return the splitted stuff | ||
| 2016-07-07 18:05 <shrox> cedk: Okay. A separate function take that and dump in the zipfile. | ||
| 2016-07-07 18:06 -!- frispete(~frispete@p54A90CBF.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-07-07 18:09 <cedk> shrox: it is just an example, you should try to apply a similar simple pattern | ||
| 2016-07-07 18:09 <shrox> cedk: Okay. Will do. | ||
| 2016-07-07 19:02 -!- aasnan(~angel@48.red-83-45-194.dynamicip.rima-tde.net) has left #tryton | ||
| 2016-07-07 19:02 -!- yangoon_rm(~mathiasb@137.158.23.210) has joined #tryton | ||
| 2016-07-07 19:23 -!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton | ||
| 2016-07-07 20:01 -!- frispete(~frispete@p54A90CBF.dip0.t-ipconnect.de) has left #tryton | ||
| 2016-07-07 20:36 -!- yangoon_rm(~mathiasb@137.158.23.210) has joined #tryton | ||
| 2016-07-07 21:01 -!- kstenger1(~karla@r186-48-35-30.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-07-07 23:32 -!- JosDzG(~Thunderbi@fixed-188-72-187-188-72-36.iusacell.net) has joined #tryton | ||
| 2016-07-07 23:37 -!- yangoon_rm(~mathiasb@137.158.23.210) has joined #tryton |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!