| chat.freenode.net #tryton log beginning Wed Mar 16 00:00:01 CET 2016 | ||
| 2016-03-16 01:01 -!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton | ||
| 2016-03-16 01:09 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2016-03-16 01:23 -!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton | ||
| 2016-03-16 07:08 -!- ccaz(~ccr@ax313-1-82-66-159-99.fbx.proxad.net) has joined #tryton | ||
| 2016-03-16 07:40 -!- frispete(~frispete@p54A91DDF.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-03-16 07:54 -!- dj_xatra(~dj_xatra@217.166.83.130) has joined #tryton | ||
| 2016-03-16 08:10 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2016-03-16 08:11 -!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton | ||
| 2016-03-16 08:29 -!- udono(~udono@ip-178-202-239-138.hsi09.unitymediagroup.de) has joined #tryton | ||
| 2016-03-16 08:35 -!- gytis_(~gytis@46.189.67.23) has joined #tryton | ||
| 2016-03-16 08:37 -!- kstenger(~karla@r186-50-22-43.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-03-16 08:52 -!- rpit(~rpit@2a02:908:e672:9420:56ee:75ff:fe0d:d3c7) has joined #tryton | ||
| 2016-03-16 08:53 -!- mrichez(~smuxi@mail.saluc.com) has joined #tryton | ||
| 2016-03-16 09:28 -!- nicoe(~nicoe@balisto.wifi.b2ck.com) has joined #tryton | ||
| 2016-03-16 09:36 -!- sebd(~seb@ldd.lo.ldd.fr) has joined #tryton | ||
| 2016-03-16 09:51 -!- jp111(0e8b5206@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.82.6) has joined #tryton | ||
| 2016-03-16 10:01 -!- gytis_(~gytis@p5099a051.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-03-16 10:13 -!- udono(~udono@ip-178-202-239-138.hsi09.unitymediagroup.de) has joined #tryton | ||
| 2016-03-16 10:44 -!- gytis(~gytis@p5099a051.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-03-16 11:34 -!- gytis(~gytis@p5099a051.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-03-16 11:49 -!- meigallodixital(~chatzilla@249.135.116.91.static.reverse-mundo-r.com) has joined #tryton | ||
| 2016-03-16 12:04 -!- mariomop(~quassel@181.92.3.12) has joined #tryton | ||
| 2016-03-16 12:46 -!- gytis_(~gytis@k250.nfq.lt) has joined #tryton | ||
| 2016-03-16 13:19 -!- gytis_(~gytis@p5099a051.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-03-16 13:36 -!- smarro(~sebastian@190.14.157.18) has joined #tryton | ||
| 2016-03-16 13:38 -!- gytis(~gytis@p5099a051.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-03-16 14:32 -!- shrox(shrox@nat/iiit/x-himheibabsmnqjev) has joined #tryton | ||
| 2016-03-16 14:56 -!- jp111(0e8b5206@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.82.6) has joined #tryton | ||
| 2016-03-16 15:31 <jp111> cedk: Hi I am trying to setup tryton on my system. Can you describe the database setup in detail. I have cloned tryton and trytond and ran python setup.py install for each. I am new to postgres. | ||
| 2016-03-16 15:34 -!- gytis_(~gytis@k250.nfq.lt) has joined #tryton | ||
| 2016-03-16 15:35 <cedk> jp111: it is explained here: http://doc.tryton.org/3.8/trytond/doc/topics/setup_database.html#topics-setup-database | ||
| 2016-03-16 15:43 <jp111> cedk: I follwed the steps as mentioned | ||
| 2016-03-16 15:43 <jp111> I first ran bin/trytond | ||
| 2016-03-16 15:43 <jp111> This is my config file http://pastebin.com/hF5KLK6Z | ||
| 2016-03-16 15:44 <jp111> Then i ran the command sudo bin/trytond -c config.ini -d trytond --all | ||
| 2016-03-16 15:44 <jp111> It is stuck at this point | ||
| 2016-03-16 15:44 <jp111> Also I am behind proxy, can that be a problem ? | ||
| 2016-03-16 15:47 <cedk> jp111: was there a problem to run the command? | ||
| 2016-03-16 15:48 <jp111> https://www.filepicker.io/api/file/lReUZxqFTayVTZD5TKQI?signature=5a068b835d0bd3fd624b9adf3e7e1f601407f00d8224326175aae28df0c62b18&policy=eyJleHBpcnkiOjE0NTgxNDI5NDZ9 | ||
| 2016-03-16 15:49 <jp111> Initially there was an error but then I ran bin/trytond in another tab and after that rerunning the command.. but it's stuck like this since | ||
| 2016-03-16 15:49 -!- Timitos(~kpreisler@host-88-217-184-172.customer.m-online.net) has joined #tryton | ||
| 2016-03-16 15:50 <jp111> This is how I created a postgres db - | ||
| 2016-03-16 15:50 <jp111> sudo -u postgres createdb tryton-db | ||
| 2016-03-16 15:52 <cedk> jp111: since how long? | ||
| 2016-03-16 15:52 <cedk> cedk: you can run it with the verbose option | ||
| 2016-03-16 15:53 <cedk> jp111: by the way, why are you using sudo? | ||
| 2016-03-16 15:53 <cedk> jp111: you must also create the database using the same user as the one you run trytond | ||
| 2016-03-16 15:55 <jp111> https://www.filepicker.io/api/file/af4gctkER7GpEHIJElLp?signature=b2f43f1c6d47a888e3767ca4c5217ad3e02bf92ca01e08a5ee5891d243ec3692&policy=eyJleHBpcnkiOjE0NTgxNDMzNDZ9 | ||
| 2016-03-16 15:55 <jp111> This is the verbose output | ||
| 2016-03-16 15:55 <jp111> the user is root that's why I ran with sudo | ||
| 2016-03-16 15:56 <cedk> jp111: but you create the database with the postgres user | ||
| 2016-03-16 15:57 <cedk> this is very strange to use root (and particulary unsecure) | ||
| 2016-03-16 15:58 <jp111> cedk: Can you tell me how to create database with particular user. | ||
| 2016-03-16 16:00 <pokoli> jp111: from postgresql use you can run: createdb <db_name> --owner=<username> | ||
| 2016-03-16 16:01 <pokoli> from postgres user (or another postgresql admin user) | ||
| 2016-03-16 16:01 <kstenger> also use the same database name when you pass the -d parameter to trytond | ||
| 2016-03-16 16:03 <cedk> jp111: also you should create a user in postgresql with command: createuser | ||
| 2016-03-16 16:06 -!- meigallodixital(~meigallod@249.135.116.91.static.reverse-mundo-r.com) has joined #tryton | ||
| 2016-03-16 16:49 -!- JosDzG(~Thunderbi@187.188.72.34) has joined #tryton | ||
| 2016-03-16 16:50 -!- vivekjain(0e8b5206@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.82.6) has joined #tryton | ||
| 2016-03-16 16:54 -!- perilla(~perilla@corp-190-57-169-210-cue.puntonet.ec) has joined #tryton | ||
| 2016-03-16 16:58 -!- perilla(~perilla@corp-190-57-169-210-cue.puntonet.ec) has joined #tryton | ||
| 2016-03-16 17:16 -!- gytis_(~gytis@p5099a051.dip0.t-ipconnect.de) has joined #tryton | ||
| 2016-03-16 17:24 <vivekjain> cedk: Hi while setting up the databse using bin/trytond -c config.ini -d testdb --all | ||
| 2016-03-16 17:24 <vivekjain> I am getting the following error | ||
| 2016-03-16 17:24 <vivekjain> http://pastebin.com/dX9Qahr6 | ||
| 2016-03-16 17:28 <cedk> vivekjain: looks like you did not define correctly in the configuration the backend name | ||
| 2016-03-16 17:30 <vivekjain> cedk: My config.ini file http://pastebin.com/T4M3Waud | ||
| 2016-03-16 17:30 <vivekjain> I have placed it in the root dorectory of trytond | ||
| 2016-03-16 17:33 <cedk> vivekjain: or you don't have psycopg2 installed | ||
| 2016-03-16 17:37 <vivekjain> cedk: Thanks it worked. | ||
| 2016-03-16 17:43 <vivekjain> cedk: When i try to host/databse information in the tryton. It shows connection error: Bad username/password. | ||
| 2016-03-16 17:43 <vivekjain> I am entering the correct username and password | ||
| 2016-03-16 17:44 <vivekjain> same as i have specified in config.ini file | ||
| 2016-03-16 17:44 <cedk> vivekjain: this is not that credential | ||
| 2016-03-16 17:44 <cedk> vivekjain: in config file it is for the database connection | ||
| 2016-03-16 17:44 <cedk> vivekjain: when you have initialize the database, trytond should have ask you to set the admin password | ||
| 2016-03-16 17:45 <vivekjain> no it din't asked me to set the password | ||
| 2016-03-16 17:46 <vivekjain> This is the log of the command http://pastebin.com/veD2f4ai | ||
| 2016-03-16 17:47 <cedk> vivekjain: if you had a crash before then it will not ask at the second tentative | ||
| 2016-03-16 17:47 <cedk> vivekjain: you have to drop the database and redo the initialisation to succeed in one shot | ||
| 2016-03-16 17:48 <cedk> there is an issue to allow to set the password after: https://bugs.tryton.org/issue5385 | ||
| 2016-03-16 18:02 <vivekjain> cedk: Again after dropping the database it asked for the password. I have kept it same as my db password. | ||
| 2016-03-16 18:02 <vivekjain> But it is giving me the same error again | ||
| 2016-03-16 18:02 <vivekjain> What is the username ? | ||
| 2016-03-16 18:02 <vivekjain> *What is username ? | ||
| 2016-03-16 18:02 <kstenger> vivekjain: admin | ||
| 2016-03-16 18:03 <vivekjain> kstenger: Still giving Connection error | ||
| 2016-03-16 18:05 -!- smarro(~sebastian@cust-138-45-13-200.trynet.com.ar) has joined #tryton | ||
| 2016-03-16 18:06 <cedk> vivekjain: maybe the client is not talking to the server | ||
| 2016-03-16 18:07 <vivekjain> cedk: Host is localhost:8000 | ||
| 2016-03-16 18:07 <kstenger> the port is not set un the config.ini uri, should it? | ||
| 2016-03-16 18:08 <vivekjain> no port is not set in the config.ini | ||
| 2016-03-16 18:09 <vivekjain> I have kept the profile empty | ||
| 2016-03-16 18:11 <cedk> vivekjain: is the server running? | ||
| 2016-03-16 18:11 <vivekjain> Yes i have run the server using bin/trytond | ||
| 2016-03-16 18:11 <kstenger> did you add -c config.ini ? | ||
| 2016-03-16 18:11 <vivekjain> kstenger: no | ||
| 2016-03-16 18:11 <kstenger> do so | ||
| 2016-03-16 18:12 <vivekjain> kstenger: Thanks it worked | ||
| 2016-03-16 18:13 <kstenger> :-) | ||
| 2016-03-16 18:25 -!- JosDzG(~Thunderbi@187.188.72.34) has joined #tryton | ||
| 2016-03-16 18:29 -!- Telesight(~anthony@4dae0c97.ftth.telfortglasvezel.nl) has joined #tryton | ||
| 2016-03-16 19:43 -!- carlos__(58089537@gateway/web/freenode/ip.88.8.149.55) has joined #tryton | ||
| 2016-03-16 19:43 -!- vivekjain(0e8b5206@gateway/web/cgi-irc/kiwiirc.com/ip.14.139.82.6) has joined #tryton | ||
| 2016-03-16 19:45 -!- shivansh(~quassel@14.139.243.163) has joined #tryton | ||
| 2016-03-16 19:46 <carlos__> hi, to connect to a tryton server i must configure trytond.conf with: [jsonrpc] listen= 192.167.1138*:8000 ? is this correct? do i have to configure something else? | ||
| 2016-03-16 19:46 <cedk> carlos__: you must remove '*', it is not a valid IP | ||
| 2016-03-16 19:47 <carlos__> ok, and then it should work like that or i need to configure anything else? | ||
| 2016-03-16 19:47 <cedk> carlos__: see http://doc.tryton.org/3.8/trytond/doc/index.html#first-steps | ||
| 2016-03-16 19:57 <carlos__> right, there are lots of instructions there but cant find a clear guidance related to what are the configurations to acces your server from external connection... | ||
| 2016-03-16 20:10 <kstenger> carlos__: is the port open for outside access? what do you get when you try to connectfrom outside? does the local connection work? | ||
| 2016-03-16 20:11 <vivekjain> kstenger: Where are the docs for web client for tryton sao ? | ||
| 2016-03-16 20:17 <kstenger> vivekjain: as sao is pretty new it seems no docs are available, is this right cedk? | ||
| 2016-03-16 20:17 <kstenger> altough you may find a lot of information on how to install it in the mailing lists | ||
| 2016-03-16 20:17 <vivekjain> kstenger: I found one but it seems to be in spanish http://wiki.tryton-erp.es/SAO | ||
| 2016-03-16 20:19 <kstenger> vivekjain: that happens, there is a lot of unofficial docs around for all tryton stuff, and it's still pretty good as the spanish community is pretty large | ||
| 2016-03-16 20:20 <kstenger> which was your question about sao? it may help to get the right answer :-) | ||
| 2016-03-16 20:24 <jp111> cedk: I was able to initialize the database. What credentials do I provide at the login prompt | ||
| 2016-03-16 20:24 <vivekjain> jp111: username: admin | ||
| 2016-03-16 20:24 <vivekjain> password: you would have been prompted for password while setting up the database,that password | ||
| 2016-03-16 20:25 -!- aroncero(~aroncero@86.63.19.153) has joined #tryton | ||
| 2016-03-16 20:27 <kstenger> jp111: you may like to read the chat above as we just helped vivekjain do the same | ||
| 2016-03-16 20:27 <jp111> kstenger: sure | ||
| 2016-03-16 20:32 <vivekjain> kstenger: While trying to install sao, when i ran npm install .I am getting following error. http://pastebin.com/88GfGHFt | ||
| 2016-03-16 20:32 <vivekjain> I am behind proxy | ||
| 2016-03-16 20:38 -!- smarro(~sebastian@cust-154-45-13-200.trynet.com.ar) has joined #tryton | ||
| 2016-03-16 20:38 <carlos__> The local connection work. The por is open! when i try to connect with the client from an external connection it is not able to connect! | ||
| 2016-03-16 20:40 -!- kstenger1(~karla@r186-54-16-114.dialup.adsl.anteldata.net.uy) has joined #tryton | ||
| 2016-03-16 20:46 <kstenger> vivekjain: sorry that's not question that I can answer | ||
| 2016-03-16 20:48 <carlos__> cedk: my configuration file is like this: http://pastebin.com/raw/9vcudJwH . Locally i can acces the server from other machines. Port is open http://pastebin.com/raw/LVifmmDp what are posible reasons i canot connect the server? | ||
| 2016-03-16 20:50 <kstenger> carlos__: try putting 'listen = *:8000' | ||
| 2016-03-16 20:51 <carlos__> going to try that... brb ; ) | ||
| 2016-03-16 20:57 <kstenger> vivekjain: googling a bit I found this, but I can't tell if it's accurate as I'm not familiar with js development (yet). I suggest read it and carefully try out suggestions. http://tips.tutorialhorizon.com/2015/11/13/npm-err-weird-error-1/ | ||
| 2016-03-16 20:58 <vivekjain> kstenger: Thanks I installed it finally. I needed to make a .bowerrc file where i can set the proxies | ||
| 2016-03-16 20:58 <kstenger> vivekjain: I'm glad you figured it out! | ||
| 2016-03-16 20:58 <vivekjain> kstenger: I am struggling with a doc a little bit. What we have to do after running grunt. grunt command created the dist folder. | ||
| 2016-03-16 20:58 <vivekjain> Now how do i see it on localhost | ||
| 2016-03-16 20:59 <kstenger> vivekjain: as far as I know, you should run the server, and it should allow access to both clients (web and gtk) | ||
| 2016-03-16 21:00 <vivekjain> kstenger: How to run the server ? | ||
| 2016-03-16 21:00 <vivekjain> you mean trytond ? | ||
| 2016-03-16 21:00 <kstenger> vivekjain: yes | ||
| 2016-03-16 21:01 <vivekjain> kstenger: Is there no index.html file present ? | ||
| 2016-03-16 21:01 <kstenger> vivekjain: yes, I see it in the sources root folder | ||
| 2016-03-16 21:02 <vivekjain> Is there any url which i can hit to ensure that the installation was successfull | ||
| 2016-03-16 21:07 <vivekjain> kstenger: ^ | ||
| 2016-03-16 21:08 <kstenger> vivekjain: I don't remember if the port is the same as for tryton gtk client, but you should visit the same url you connect to from the client in the browser. If it doesn't work, try port 80 as I'm not sure what it expects, otherwise someone else will have to clarify this | ||
| 2016-03-16 21:09 <kstenger> vivekjain: maybe there is some information on the output of the server, try --verbose if no output | ||
| 2016-03-16 21:12 <cedk> vivekjain: the webclient is served on the same address and port as the GTK client | ||
| 2016-03-16 21:12 <vivekjain> cedk: It says in the doc in the lastline something about jsonpath_data .. | ||
| 2016-03-16 21:12 <vivekjain> where do we need to set it ? | ||
| 2016-03-16 21:13 <cedk> vivekjain: in the configuration of trytond | ||
| 2016-03-16 21:13 <vivekjain> cedk: mean config.ini ? | ||
| 2016-03-16 21:13 <cedk> vivekjain: be careful if you use the trunk the configuration section has changed | ||
| 2016-03-16 21:15 <vivekjain> cedk: is it in config.py in the trytond directory ? | ||
| 2016-03-16 21:16 <kstenger> cedk: is there no official docs on sao yet? Would be helpful for those trying to understand the sao world *points at self* :-) | ||
| 2016-03-16 21:16 <cedk> vivekjain: no the configuration of trytond | ||
| 2016-03-16 21:16 <cedk> vivekjain: http://doc.tryton.org/3.8/trytond/doc/topics/configuration.html#topics-configuration | ||
| 2016-03-16 21:17 <cedk> kstenger: there is in the README | ||
| 2016-03-16 21:17 <kstenger> vivekjain: the config.ini in your case, but it can be called however you want as it is a parameter to the server | ||
| 2016-03-16 21:17 <kstenger> cedk: oh thanks :-) | ||
| 2016-03-16 21:18 <kstenger> I was actually meaning something more verbose, but ok :-D | ||
| 2016-03-16 21:19 <cedk> kstenger: I don't see what could be said more | ||
| 2016-03-16 21:23 <shrox> cedk: After I make changes and reupload code for review (after making changes as mentioned in the first review), all I have to do is use the same upload.py utility file again as is, correct? And I should also send a message on the bug tracker, if I understand correctly. | ||
| 2016-03-16 21:23 <vivekjain> cedk: under what section should i write jsonpath_data should it be webdav or jsonrpc ? | ||
| 2016-03-16 21:25 <cedk> shrox: you must pass the review id with '-i' | ||
| 2016-03-16 21:25 <cedk> vivekjain: jsonrpc, it is written in the README of sao | ||
| 2016-03-16 21:25 <shrox> shrox: Ah, okay. Okay. | ||
| 2016-03-16 21:28 <vivekjain> cedk: Can you point me to the README of sao. Unable to find anything about sao except http://wiki.tryton-erp.es/SAO | ||
| 2016-03-16 21:29 <kstenger> vivekjain: the sao source files hg.tryton.org/sao/ | ||
| 2016-03-16 21:30 <carlos__> still cant conect to the server from external connection. i still have this configuration file (http://pastebin.com/raw/9vcudJwH) which i tried also with (listen = *:8000) and port is open in the pc i have the server ( http://pastebin.com/raw/LVifmmDp) do i have to do somethin in the pc i have the client? | ||
| 2016-03-16 21:30 <cedk> vivekjain: it is in the repository | ||
| 2016-03-16 21:30 <cedk> carlos__: which version? | ||
| 2016-03-16 21:30 <carlos__> all last version | ||
| 2016-03-16 21:30 <cedk> carlos__: number? | ||
| 2016-03-16 21:31 <carlos__> client 3.8.4 server 3.8.3รง | ||
| 2016-03-16 21:32 <vivekjain> cedk: Login is same as tryton gui ? | ||
| 2016-03-16 21:33 <vivekjain> I am unable to login .. | ||
| 2016-03-16 21:33 <cedk> carlos__: and trytond says it is listening to the IP address in verbose mode? | ||
| 2016-03-16 21:33 <cedk> vivekjain: yes | ||
| 2016-03-16 21:34 <vivekjain> using the same credentials as in GUI but not able to login.Database: testdb | ||
| 2016-03-16 21:34 <vivekjain> Login: admin | ||
| 2016-03-16 21:34 <vivekjain> password: which the trytond server asked initially | ||
| 2016-03-16 21:35 <carlos__> dont know how to check that... | ||
| 2016-03-16 21:35 <carlos__> trytond 6381 root 3u IPv4 60301 0t0 TCP 192.168.1.36:8000 (LISTEN) | ||
| 2016-03-16 21:35 <kstenger> carlos__: run the server with the --verbose parameter and watch the output | ||
| 2016-03-16 21:35 <cedk> carlos__: in log in verbose mode | ||
| 2016-03-16 21:35 <cedk> carlos__: type: trytond --help | ||
| 2016-03-16 21:36 <cedk> vivekjain: then you are not connecting to the same server | ||
| 2016-03-16 21:36 <carlos__> yes it says starting json protocol on the ip+port | ||
| 2016-03-16 21:36 <cedk> carlos__: so you should have a firewall somewhere | ||
| 2016-03-16 21:37 <carlos__> already allowed in ubuntu where i have the server... do i have to open port or something on client also? | ||
| 2016-03-16 21:38 <carlos__> is the correct to listen listen=*8000 or listen="ip":8000 ? just so i get that out of the way.... | ||
| 2016-03-16 21:38 <vivekjain> cedk: I think i am connected to the same server. Because whenever i enter a wrong url the server log says code 404, message File not found. | ||
| 2016-03-16 21:39 <cedk> carlos__: don't understand the question | ||
| 2016-03-16 21:39 <cedk> vivekjain: it is not possible that the password works for GTK and not sao | ||
| 2016-03-16 21:40 <carlos__> the correct configuration in the server configuration file (trytond.conf) is [json...] listen = :*8000 or listen = "serverip":8000 ? | ||
| 2016-03-16 21:42 <cedk> carlos__: any of them | ||
| 2016-03-16 21:43 <cedk> carlos__: it is: 1.2.3.4:8000 or *:8000 | ||
| 2016-03-16 21:43 <carlos__> so i probably have to check for firewall on both machines then... | ||
| 2016-03-16 21:45 -!- smarro(~sebastian@cust-156-45-13-200.trynet.com.ar) has joined #tryton | ||
| 2016-03-16 22:10 -!- umeshksingla_(uid137324@gateway/web/irccloud.com/x-dgmigejsadfmmcpw) has joined #tryton | ||
| 2016-03-16 22:12 -!- shrox(shrox@nat/iiit/x-vcptofsgcejdilol) has joined #tryton | ||
| 2016-03-16 22:52 -!- umeshksingla_(uid137324@gateway/web/irccloud.com/x-dgmigejsadfmmcpw) has left #tryton | ||
| 2016-03-16 23:01 -!- bvillasanti(~bvillasan@138.117.20.246) has joined #tryton | ||
| 2016-03-16 23:15 <shrox> cedk: The 'For committers' in the tryton 'how to contribute' is for seasoned contributors, right? | ||
| 2016-03-16 23:20 <cedk> shrox: yes | ||
| 2016-03-16 23:24 <shrox> cedk: Okay. Thanks for the review. | ||
| 2016-03-16 23:36 <shrox> cedk: "Please try to submit both reviews in the same time, it will be easier to review." Can you elaborate on this? Didn't understand what you meant. Do you mean the patches to the reviews you've made? | ||
| 2016-03-16 23:43 <cedk> shrox: no I mean the patch for the other module | ||
| 2016-03-16 23:44 <shrox> cedk: Oh the account_invoice module you mean? | ||
| 2016-03-16 23:45 <cedk> shrox: yes | ||
| 2016-03-16 23:48 <shrox> cedk: I actually wasn't aware that I was supposed to edit that too. I'll do that. Redundant code, of course. I'll use the same issue number and append the patch to that. | ||
| 2016-03-16 23:52 <cedk> shrox: yes it is one changement | ||
| 2016-03-16 23:53 <shrox> cedk: cool | ||
| 2016-03-16 23:56 -!- niki(~niki@0x3e2c8719.mobile.telia.dk) has joined #tryton |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!