IRC logs of #tryton for Saturday, 2014-01-04

chat.freenode.net #tryton log beginning Sat Jan 4 00:00:01 CET 2014
2014-01-04 17:53 <hiaselhans> hi i found a little mistake with unoconv...
2014-01-04 17:53 <hiaselhans> the file stream was not closed
2014-01-04 17:54 <hiaselhans> i made a patch should i send the one single line? :)
2014-01-04 18:13 <Pilou> hiaselhans: you should create a bug report and a codereview (See http://code.google.com/p/tryton/wiki/HowtoContribute)
2014-01-04 18:17 <hiaselhans> ok, like this?: https://bugs.tryton.org/issue3578
2014-01-04 18:31 <Pilou> hiaselhans: you should create a codereview (here http://codereview.tryton.org/), add a reference to the codereview in a comment of https://bugs.tryton.org/issue3578. When the review is validated by cedk, you will be able to a patch to this issue.
2014-01-04 18:34 <Pilou> (as here https://bugs.tryton.org/issue3076)
2014-01-04 19:20 <hiaselhans> ok, here it is.. http://codereview.tryton.org/2561002/
2014-01-04 19:20 <hiaselhans> but i have a question:
2014-01-04 19:21 <hiaselhans> i want to make different headers, and i dont understand cedk's response from bugtracker (maybe i was too fast with bug-reporting)
2014-01-04 19:22 <hiaselhans> even if i use the original sale.odt and header_A4.odt and i create a new report, i get an error 500
2014-01-04 19:23 <hiaselhans> if i dont use the header it works, but the fields are not translated...
2014-01-04 19:24 <yangoon> hiaselhans: you should give an example on the bugtracker, what you are exactly doing with which error and if your patch solves the problem
2014-01-04 19:27 <Pilou> hiaselhans: about the cedk comment, check the doc http://docs.python.org/2.7/library/stdtypes.html#file.close
2014-01-04 19:27 <cedk> hiaselhans: did you use the CompanyReport instead of Report?
2014-01-04 19:31 <cedk> hiaselhans: by the way, header report will be removed soon: https://bugs.tryton.org/issue577
2014-01-04 19:39 <hiaselhans> sorry, i was confused after playing around with the code because i had to switch to file-converting due to: https://github.com/dagwieers/unoconv/issues/156
2014-01-04 19:41 <hiaselhans> excuse this stupid question, but how to make a company report?
2014-01-04 19:55 <cedk> hiaselhans: http://hg.tryton.org/modules/sale/file/7dc5451fe949/sale.py#l1428
2014-01-04 20:02 <hiaselhans> thanks...

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!