| chat.freenode.net #tryton log beginning Sun Apr 29 00:00:01 CEST 2012 | ||
| 2012-04-29 01:29 <meanmicio> cedk : ping | ||
| 2012-04-29 01:30 <meanmicio> cedk : the '' vs None issue is fixed at changeset 188:e2cb093fa9f9 | ||
| 2012-04-29 01:34 <cedk> meanmicio: ok | ||
| 2012-04-29 01:34 <cedk> meanmicio: just a comment: | ||
| 2012-04-29 01:35 <cedk> 'ref' in vals.keys() -> 'ref' in vals | ||
| 2012-04-29 01:35 <cedk> meanmicio: it is better, the first one create a list to check when the second use the index of the dict | ||
| 2012-04-29 01:36 <cedk> meanmicio: and instead of: if vals['ref'] == '': -> if not vals['ref']: | ||
| 2012-04-29 01:36 <cedk> meanmicio: also, I will do a copy of vals before modifying it | ||
| 2012-04-29 01:36 <cedk> meanmicio: I can make the change if you want | ||
| 2012-04-29 01:36 <meanmicio> cedk : ok . you want to update it or I'll do it ? | ||
| 2012-04-29 01:36 <meanmicio> cedk : great ! | ||
| 2012-04-29 01:45 <cedk> meanmicio: done | ||
| 2012-04-29 01:45 <meanmicio> cedk : excellent ! Functional and optimized ;-) | ||
| 2012-04-29 02:08 <cedk> meanmicio: the copy is important to not have side effect |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!