| chat.freenode.net #tryton log beginning Mon Aug 2 00:00:02 CEST 2010 | ||
| 2010-08-02 00:36 -!- digitalsatori(~tony@116.233.249.147) has joined #tryton | ||
| 2010-08-02 03:01 -!- gremly(~gremly@201.244.193.238) has joined #tryton | ||
| 2010-08-02 04:12 -!- digitalsatori(~tony@116.233.249.147) has joined #tryton | ||
| 2010-08-02 07:01 -!- mr_amit(~amit@117.254.179.209) has joined #tryton | ||
| 2010-08-02 08:42 -!- Timitos(~timitos@88.217.184.172) has joined #tryton | ||
| 2010-08-02 09:04 -!- enlightx(~enlightx@62-207.203-62.cust.bluewin.ch) has joined #tryton | ||
| 2010-08-02 09:48 -!- tekoholic(~quassel@184-96-85-143.hlrn.qwest.net) has joined #tryton | ||
| 2010-08-02 10:02 -!- MikaelPettersson(~chatzilla@host191-12.bornet.net) has joined #tryton | ||
| 2010-08-02 11:05 -!- essich(~essich@p4FCF92F9.dip0.t-ipconnect.de) has joined #tryton | ||
| 2010-08-02 11:41 -!- cedk(~cedk@gentoo/developer/cedk) has joined #tryton | ||
| 2010-08-02 12:19 -!- mr_amit(~amit@117.254.22.125) has joined #tryton | ||
| 2010-08-02 12:29 -!- paepke(~paepke@p4FEB0F6E.dip0.t-ipconnect.de) has joined #tryton | ||
| 2010-08-02 12:33 -!- MikaelP(~chatzilla@cust-IP-11.data.tre.se) has joined #tryton | ||
| 2010-08-02 13:19 -!- gremly(~gremly@201.244.193.238) has joined #tryton | ||
| 2010-08-02 13:20 -!- gremly(~gremly@201.244.193.238) has joined #tryton | ||
| 2010-08-02 13:30 -!- gremly(~gremly@201.244.193.238) has joined #tryton | ||
| 2010-08-02 13:32 -!- gremly(~gremly@201.244.193.238) has joined #tryton | ||
| 2010-08-02 13:41 -!- enlightx(~enlightx@62-207.203-62.cust.bluewin.ch) has joined #tryton | ||
| 2010-08-02 14:10 -!- pheller(~pheller@pool-173-48-216-195.bstnma.fios.verizon.net) has joined #tryton | ||
| 2010-08-02 14:19 -!- MikaelPettersson(~chatzilla@cust-IP-11.data.tre.se) has joined #tryton | ||
| 2010-08-02 14:32 -!- digitalsatori(~tony@116.233.249.147) has joined #tryton | ||
| 2010-08-02 14:47 -!- pheller(~pheller@c1fw226.constantcontact.com) has joined #tryton | ||
| 2010-08-02 15:09 -!- bechamel(~user@host-85-201-159-186.brutele.be) has joined #tryton | ||
| 2010-08-02 15:56 -!- pepeu(~manuel@201.155.193.192) has joined #tryton | ||
| 2010-08-02 16:22 -!- woakas(~woakas@pcsp163-59.supercabletv.net.co) has joined #tryton | ||
| 2010-08-02 16:36 -!- tekknokrat(~lila@188.106.99.200) has joined #tryton | ||
| 2010-08-02 16:53 -!- pepeu(~manuel@201.155.193.192) has joined #tryton | ||
| 2010-08-02 17:21 -!- plantian(~ian@c-69-181-194-95.hsd1.ca.comcast.net) has joined #tryton | ||
| 2010-08-02 17:22 <pheller> anyone around that can answer a question re: converting modules for the transaction system? | ||
| 2010-08-02 17:30 <Timitos> pheller: maybe i can help you | ||
| 2010-08-02 17:30 <pheller> so I am converting Company..... | ||
| 2010-08-02 17:31 <pheller> see here | ||
| 2010-08-02 17:31 <pheller> http://codereview.appspot.com/1853047/diff/10001/11002 | ||
| 2010-08-02 17:31 <pheller> line 281 and 291.... | ||
| 2010-08-02 17:31 <pheller> so I know I must include "localcontext=None" in the function signature | ||
| 2010-08-02 17:32 <pheller> ... and that I must pass localcontext=localcontext in the call to super(...) in each function.... | ||
| 2010-08-02 17:32 <pheller> and according to ced in the most recent comment, I must instead set the values in localcontext. so, for the company report, localcontext['company'] = user.company.id | ||
| 2010-08-02 17:33 <pheller> no problem.... but, in the LetterReport, it doesn't make sense to do this ... because user is already set exactly like this in the localcontext of the "Report" class (from which LetterReport inherits) | ||
| 2010-08-02 17:45 <Timitos> pheller: i think you are right. looks like it is not necessary. the behavior of the parse method changed a little bit. | ||
| 2010-08-02 17:47 <pheller> Right, so if it is unnecessary for the LetterReport, then almost everything for the LetterReport is unnecessary, except maybe the _name, so that everything continues to work.... | ||
| 2010-08-02 17:48 <Timitos> cedk: because of this line http://hg.tryton.org/hgwebdir.cgi/1.6/trytond/file/aac47c8adb68/trytond/report/report.py#l149 it was possible to update the user in localcontext to a value set in context. this is no more possible in trunk. | ||
| 2010-08-02 17:48 <Timitos> cedk: do you see problems with this? | ||
| 2010-08-02 17:50 <Timitos> cedk: i must correct. it is no more possible with trunk + transaction patch | ||
| 2010-08-02 17:52 <Timitos> pheller: you are right. if it is like we think only the _name needs to stay. but i think you should wait for an confirmation by cedk | ||
| 2010-08-02 17:57 -!- blast_hardcheese(~blast_har@dsl092-043-124.lax1.dsl.speakeasy.net) has joined #tryton | ||
| 2010-08-02 18:06 -!- juanfer(~juanfer@201.244.237.64) has joined #tryton | ||
| 2010-08-02 18:08 <Timitos> pheller: but you need to fix the signature of the parse function in any case: def parse(self, report, objects, datas, localcontext=None): | ||
| 2010-08-02 18:19 <pheller> Timitos: yes, I understand. I'm waiting for cedk before I submit my final patchset. | ||
| 2010-08-02 18:20 <pheller> one more question regarding the same patchset I posted.... line 153, and 184. | ||
| 2010-08-02 18:20 <pheller> the indent should be 4 more spaces than the line above? or should it be 8 more? | ||
| 2010-08-02 18:21 <pheller> I think 184 (and 185) look right, but ced says 8 spaces? | ||
| 2010-08-02 18:23 <Timitos> pheller: 8 more spaces thant the line above | ||
| 2010-08-02 18:23 <pheller> huh, really. I thought pep-008 said only 4. | ||
| 2010-08-02 18:24 <Timitos> pheller: we use 8 spaces for multiline statements | ||
| 2010-08-02 18:25 <pheller> ok, I will conform to this convention going forward then | ||
| 2010-08-02 18:30 <Timitos> pheller: there is an exception for this 8 spaces rule. when there is a multiline list you should use 4 space like here: http://hg.tryton.org/hgwebdir.cgi/modules/sale/file/7c034ebad23f/sale.py#l33 | ||
| 2010-08-02 18:30 <Timitos> pheller: i hope that i explained it right as it is not yes documented. | ||
| 2010-08-02 18:31 <pheller> yes a coding guideline document would be very helpful | ||
| 2010-08-02 18:31 <pheller> that last one is a little surprising, because the closing brace is at the same indent as the first column of the first line. | ||
| 2010-08-02 18:31 <Timitos> pheller: this is the only existing one: http://code.google.com/p/tryton/wiki/CodingGuidelines | ||
| 2010-08-02 18:32 <Timitos> pheller: yes. there are different versions of this in the code. i would also use 4 spaces in this case | ||
| 2010-08-02 18:33 <pheller> it's only that the line beginning "], 'State'" in your last example isn't as easy to visually parse as if it were indented more | ||
| 2010-08-02 18:34 <pheller> I'm amazed how quickly the module conversions have seemed to go, though | ||
| 2010-08-02 18:35 <pheller> by my count, just over half are complete or have at least begun | ||
| 2010-08-02 18:35 <Timitos> yes. this is great | ||
| 2010-08-02 18:36 <pheller> I really hope the SocketServer ticket can been addressed before 1.8, so I can at least develop on my Mac once again. | ||
| 2010-08-02 18:39 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2010-08-02 18:41 <pheller> cedk: if you can look at the last messages between Timitos, myself, and to you --- we need your opinion on the localcontext in reports | ||
| 2010-08-02 18:42 <cedk> pheller: I check in 5 mins | ||
| 2010-08-02 18:42 <pheller> ok, cool. thanks | ||
| 2010-08-02 18:53 <cedk> pheller: I agree | ||
| 2010-08-02 18:54 <pheller> Ok, so LetterReport will only contain _name.... | ||
| 2010-08-02 18:55 <pheller> and for CompanyReport, company is assigned with localcontext['company'] now..... | ||
| 2010-08-02 18:55 <pheller> yes? | ||
| 2010-08-02 19:23 <cedk> pheller: yes | ||
| 2010-08-02 19:25 <pheller> ok, just submitted the patchset | ||
| 2010-08-02 19:36 -!- MikaelPettersson(~chatzilla@host191-12.bornet.net) has joined #tryton | ||
| 2010-08-02 19:58 -!- mr_amit(~amit@117.254.22.196) has joined #tryton | ||
| 2010-08-02 20:06 -!- cedk(~ced@gentoo/developer/cedk) has joined #tryton | ||
| 2010-08-02 20:23 -!- tekknokrat(~lila@188.106.99.200) has joined #tryton | ||
| 2010-08-02 21:24 -!- gremly(~gremly@201.244.193.238) has joined #tryton | ||
| 2010-08-02 21:43 -!- paepke_(~paepke@p4FEB008E.dip0.t-ipconnect.de) has joined #tryton | ||
| 2010-08-02 21:57 -!- paepke(~paepke@p4FEB008E.dip0.t-ipconnect.de) has left #tryton | ||
| 2010-08-02 23:48 -!- paepke(~paepke@p5B32AFB0.dip.t-dialin.net) has joined #tryton | ||
| 2010-08-02 23:50 -!- paepke(~paepke@p5B32AFB0.dip.t-dialin.net) has joined #tryton |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!