| chat.freenode.net #tryton log beginning Fri Jul 11 00:00:02 CEST 2008 | ||
| 2008-07-11 00:28 <CIA-53> tryton: Bertrand Chenal <bch@b2ck.com> default * 157:486a4e289443 stock/move.py: Fix : allow to delete cancelled moves | ||
| 2008-07-11 00:28 <CIA-53> tryton: Bertrand Chenal <bch@b2ck.com> default * 158:9c718732a3cd stock/ (inventory.py inventory.xml): Added expected on inventory line, improved inventory update. | ||
| 2008-07-11 05:06 -!- FWiesing(n=FWiesing@194.208.185.12) has left #tryton | ||
| 2008-07-11 05:19 -!- yangoon(n=mathiasb@p549F4D97.dip.t-dialin.net) has joined #tryton | ||
| 2008-07-11 06:11 -!- kultviech(n=kultviec@p5B0D0E2F.dip0.t-ipconnect.de) has joined #tryton | ||
| 2008-07-11 07:04 -!- FWiesing(n=FWiesing@194.208.185.12) has joined #tryton | ||
| 2008-07-11 07:04 -!- FWiesing(n=FWiesing@194.208.185.12) has left #tryton | ||
| 2008-07-11 07:18 -!- ChanServ(ChanServ@services.) has joined #tryton | ||
| 2008-07-11 07:18 -!- yangoon(n=mathiasb@p549F4D97.dip.t-dialin.net) has joined #tryton | ||
| 2008-07-11 07:18 -!- CIA-53(n=CIA@208.69.182.149) has joined #tryton | ||
| 2008-07-11 07:44 -!- Timitos(n=Timitos@88.217.184.172) has joined #tryton | ||
| 2008-07-11 08:19 -!- Gedd(n=ged@77.109.115.99) has joined #tryton | ||
| 2008-07-11 08:24 -!- udono(n=udono@dynamic-unidsl-85-197-21-238.westend.de) has joined #tryton | ||
| 2008-07-11 09:58 -!- bechamel(n=user@user-85-201-14-207.tvcablenet.be) has joined #tryton | ||
| 2008-07-11 10:05 -!- cedk(n=ced@gentoo/developer/cedk) has joined #tryton | ||
| 2008-07-11 11:01 <udono> hello all | ||
| 2008-07-11 11:24 -!- markusleist(n=markus@212.14.79.210) has joined #tryton | ||
| 2008-07-11 12:00 <udono> cedk: I have some success in converting glade2py-gtk! | ||
| 2008-07-11 12:00 <udono> cedk: the way is hard... | ||
| 2008-07-11 12:00 <udono> cedk: like you mentioned before | ||
| 2008-07-11 12:01 <udono> cedk: there is no tool wich helps directly, but I use the C coverter and re-script to py-gtk by hand | ||
| 2008-07-11 12:02 <udono> cedk: but there are some design decisions we should clear before... | ||
| 2008-07-11 12:09 <udono> cedk: the tryton.glade file is 6200 Line long and the main.py is 1300 lines long. That sums up to 7500 lines. Minus 1/3 for the XML overhead in glade is 5000 lines in one file. Thats more than ugly... | ||
| 2008-07-11 12:10 <udono> I like to divide the main.py into model and view but need some help with the python classes. | ||
| 2008-07-11 12:11 <udono> My aim is to hold inside the main.py the Model and create a directory which contain all the gtk-view things one in a single file. | ||
| 2008-07-11 12:12 <udono> Is it possible to show me an example when I provide you my first convert to pygtk? | ||
| 2008-07-11 12:24 <cedk> udono: can you show me how is the code generated ? | ||
| 2008-07-11 12:25 <cedk> because I'm not sure that generator is a good solution, because glade is fill of usefull things | ||
| 2008-07-11 12:26 <udono> cedk: just open the tryton.glade with glade-2 and generate the code. | ||
| 2008-07-11 12:26 <udono> cedk: I got the login converted, and it wors | ||
| 2008-07-11 12:26 <udono> wors=works | ||
| 2008-07-11 12:27 <udono> Of course we need to overwork the final py-gtk but this is the fastest way I found... but it takes his time | ||
| 2008-07-11 12:29 <cedk> udono: I don't have generate code option in glade | ||
| 2008-07-11 12:30 <udono> cedk: its Project > build | ||
| 2008-07-11 12:30 <udono> cedk: I choose C as language | ||
| 2008-07-11 12:31 <cedk> udono: I don't have it | ||
| 2008-07-11 12:31 <udono> :-) gento, ha | ||
| 2008-07-11 12:31 <cedk> glade-3 | ||
| 2008-07-11 12:32 <cedk> maybe it comes with the gnome option | ||
| 2008-07-11 12:32 <udono> No, glade 3 doesnt support this... | ||
| 2008-07-11 12:32 <udono> I think | ||
| 2008-07-11 12:32 <udono> I use glade2 | ||
| 2008-07-11 12:32 <cedk> any way, you have C code so you must rewrite it | ||
| 2008-07-11 12:32 <udono> yes | ||
| 2008-07-11 12:32 <udono> its 90% dummyjob | ||
| 2008-07-11 12:32 <cedk> how many lines of code do you have for the login window ? | ||
| 2008-07-11 12:33 <udono> but Iam to dummy to write an XSLT parser for the job... | ||
| 2008-07-11 12:34 <cedk> udono: i think that if I write it in pygtk directly, I will have ~25 lines of code | ||
| 2008-07-11 12:36 <udono> _server_ask: 42lines, loginwindow: 84 lines | ||
| 2008-07-11 12:36 <udono> maybe it can be smarter, but Iam new to Python and to GTK... | ||
| 2008-07-11 12:37 <udono> Optimising won't be this hard if we have the converted structure... | ||
| 2008-07-11 12:37 <cedk> that why I think code convertor is bad, they generate uggly code | ||
| 2008-07-11 12:38 <cedk> udono: I think also, re-read those codes may be a good oportunity to improve those windows | ||
| 2008-07-11 12:39 <udono> cedk: yes, of course. But you know all beginning is hard and sub-optimated... | ||
| 2008-07-11 12:41 <udono> cedk: BTW I read a lot in the common.py and so on, but Its easyer for me to convert it to c, than rewrite it to py-gtk. Bring it to run and after all optimising the code... | ||
| 2008-07-11 12:42 <cedk> udono: you don't need to convert all in one shot | ||
| 2008-07-11 12:42 <cedk> udono: that is why I suggest you the login window | ||
| 2008-07-11 12:42 <udono> cedk: ok, ready | ||
| 2008-07-11 12:42 <udono> :-) | ||
| 2008-07-11 12:42 <cedk> udono: it is a small dialog box and there some example of dialog box in common.py | ||
| 2008-07-11 12:43 <cedk> udono: if you can send me, just the begining of your work, I can help you by reviewing it | ||
| 2008-07-11 12:46 <udono> cedk: This is a very good idea | ||
| 2008-07-11 12:46 <udono> I open a issue and provide the patches | ||
| 2008-07-11 12:47 <cedk> udono: good | ||
| 2008-07-11 13:16 <CIA-53> tryton: udono roundup * #176/Moving glade to pygtk: [new] Why: - more easy client translation - future integration of the webclient | ||
| 2008-07-11 13:20 <CIA-53> tryton: udono roundup * #176/Moving glade to pygtk: [chatting] First draft: Moving login dialog from glade to pygtk. See attachment patch. | ||
| 2008-07-11 13:21 <udono> cedk: done | ||
| 2008-07-11 13:21 <cedk> udono: ok I check | ||
| 2008-07-11 13:21 <udono> cedk: Thanks a lot! | ||
| 2008-07-11 13:29 <cedk> udono: first you don't need to add comment in the glade file | ||
| 2008-07-11 13:29 <cedk> udono: you can remove the call to glade instead of commenting it | ||
| 2008-07-11 13:30 <cedk> udono: try to avoid end empty space on lines | ||
| 2008-07-11 13:30 <cedk> udono: I think it will be great to have better naming for gtk object | ||
| 2008-07-11 13:31 <cedk> udono: not dialog_vbox23 but just vbox | ||
| 2008-07-11 13:31 <udono> ok | ||
| 2008-07-11 13:31 <cedk> udono: I don't see the usefull of those lines: #Start GTK | ||
| 2008-07-11 13:32 <cedk> udono: set directly the variable name that we use after instead of: host_widget = ent_host | ||
| 2008-07-11 13:33 <cedk> udono: for your remarks about the RE, there is no protocols there | ||
| 2008-07-11 13:33 <cedk> udono: it is just servername:port | ||
| 2008-07-11 13:34 <udono> cedk: but then we can avoid or filter protocols... | ||
| 2008-07-11 13:35 <cedk> udono: but we don't support different protocols | ||
| 2008-07-11 13:35 <cedk> udono: for the combo_label, I think you can set directly his content | ||
| 2008-07-11 13:36 <udono> cedk: ok, I look in common.py for examples | ||
| 2008-07-11 13:36 <cedk> udono: otherwize, it seems good | ||
| 2008-07-11 13:37 <udono> ok, thanks | ||
| 2008-07-11 13:37 <cedk> also try to not exceed 80 chars in a line | ||
| 2008-07-11 13:38 <cedk> if you can fix that, and put the 2 changeset in roundup. I will put it in the main branch | ||
| 2008-07-11 13:38 <udono> cedk: ok. But what about my ideas from beginning of our talk. Moving all the View into own small Modules? | ||
| 2008-07-11 13:39 <cedk> udono: I don't think it is a good idea, I think better will be to move DB creation etc... in his own module instead of main | ||
| 2008-07-11 13:40 <cedk> udono: because for me, it is a gtk application so it is normal to have gtk call inside | ||
| 2008-07-11 13:40 -!- kultviech(n=kultviec@p5B0D0E2F.dip0.t-ipconnect.de) has joined #tryton | ||
| 2008-07-11 13:41 <cedk> udono: but you are right that main.py is to big, it must be split in db.py, tips.py, etc ... | ||
| 2008-07-11 13:41 <udono> cedk: no problem with this, but I like to work on horizontal complexity by splitting the big thing into modules, and not on vertical complexity by having one single file... | ||
| 2008-07-11 13:42 <udono> cedk: and your idea is better than mine... its all gtk, so we should divide the classes of main.py ando not of the View part... | ||
| 2008-07-11 13:42 <cedk> udono: yes but the class Main is all about interface | ||
| 2008-07-11 13:43 <cedk> udono: yes, especially that gtk object must be link by callback to function of the object | ||
| 2008-07-11 13:43 <cedk> udono: but make one things at once | ||
| 2008-07-11 13:44 <cedk> udono: split must be done in an other changeset | ||
| 2008-07-11 13:44 <udono> cedk: ok, you are right, but its ugly for me to work on a huge file... | ||
| 2008-07-11 13:45 <cedk> udono: after the login stuff, we can split main.py and come back after with the glade stuff | ||
| 2008-07-11 13:46 <udono> cedk: yes | ||
| 2008-07-11 13:47 <cedk> udono: and by the way, it will be easier to test pyjamas with small files than one big | ||
| 2008-07-11 13:47 <udono> cedk: :-) | ||
| 2008-07-11 13:49 <udono> cedk: one thing about the combo_label you mentioned. I dont know how to do this, but iam very interesting in this, because I have problems with this function in another module... Did you know how it could work? Signals? | ||
| 2008-07-11 13:52 <cedk> udono: oups sorry, you can not set directly the text in it because there is two value possible | ||
| 2008-07-11 15:15 <udono> cedk: what is the naming convention for Variables? dialogbox = gtk.VBox() or dialog_box = gtk.VBox() | ||
| 2008-07-11 15:16 <udono> bechamel: ? | ||
| 2008-07-11 15:17 <bechamel> udono: i thing both are ok, what cedk was saiying is to avoid box6129 and other genereated names | ||
| 2008-07-11 15:17 <udono> bechamel: ok, thank you | ||
| 2008-07-11 15:21 <cedk> udono: I will use vbox = gtk.VBox() | ||
| 2008-07-11 15:37 <udono> cedk: but this is a meaningless name... you see already that it is a vbox in the caller... | ||
| 2008-07-11 15:38 <cedk> udono: I don't think, because you will use it later | ||
| 2008-07-11 15:40 <udono> cedk: you doesn't find dialog_vbox for the overall vbox of the dialog better? | ||
| 2008-07-11 15:42 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 514:451064cd85ce tryton/tryton/gui/window/ (form.py view_form/screen/screen.py): | ||
| 2008-07-11 15:42 <CIA-53> tryton: Backed out changeset 04c9af13b24f | ||
| 2008-07-11 15:42 <CIA-53> tryton: show_search is used for xxx2Many views | ||
| 2008-07-11 15:43 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 515:28f0ed01a985 tryton/: merge | ||
| 2008-07-11 15:43 <cedk> udono: I don't see what dialog means there | ||
| 2008-07-11 16:00 <udono> cedk: dialog_vbox is the primary vbox inside the main gtk.Dialog. And i.e. image_vbox is the vbox of the image, entry_password for passwordfield, button_password_change and so on... I find this is a good naming for visual identification of gui elements and their gtk constructors... | ||
| 2008-07-11 16:12 <cedk> udono: but if you change a little bit the construction of the dialog, like adding a hbox overall, you must rename all your variables | ||
| 2008-07-11 16:21 <udono> cedk: no, because than it is a dialog_hbox. And what is the alternative? entry_password, button_password_change, image_vbox is the visual and functional name... how should I name image_vbox other than this? vbox57? or vboxi? If you dont like sensefull variable names, than we can let all like they are... | ||
| 2008-07-11 16:23 <cedk> udono: ok, I don't understand well the naming rules but ok let's go with yours | ||
| 2008-07-11 17:27 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 701:67741ba06caa trytond/trytond/osv/orm.py: Fix exception error message | ||
| 2008-07-11 17:27 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 702:2d81c7d72d4d trytond/trytond/osv/orm.py: Add error message for wrong field name args | ||
| 2008-07-11 17:27 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 132:becf69798792 account/ (account.py account.xml journal.py move.py): Move code from account.type to account.account and rename it in kind. | ||
| 2008-07-11 17:27 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 74:7e7a329c4532 account_invoice/invoice.py: Move code from account.type to account.account | ||
| 2008-07-11 17:32 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 516:e868ec0434a6 tryton/tryton/gui/window/view_tree/parse.py: Improve tree view for wrong field name | ||
| 2008-07-11 18:19 -!- kultviec1(n=kultviec@p5B0D1BF1.dip0.t-ipconnect.de) has joined #tryton | ||
| 2008-07-11 18:31 -!- kultviec2(n=kultviec@p5B0D18D9.dip0.t-ipconnect.de) has joined #tryton | ||
| 2008-07-11 18:40 <udono> full of kultviecher ;-) | ||
| 2008-07-11 19:06 <kultviech> a lot of thunder and lightnings in our area | ||
| 2008-07-11 19:20 -!- kultviec1(n=kultviec@p5B0D110D.dip0.t-ipconnect.de) has joined #tryton | ||
| 2008-07-11 19:27 <CIA-53> tryton: C?dric Krier <ced@b2ck.com> default * 133:6ce2669f8e22 account/ (account.py account.xml): | ||
| 2008-07-11 19:27 <CIA-53> tryton: Change childs on account.account(.template) from Many2Many into One2Many and | ||
| 2008-07-11 19:27 <CIA-53> tryton: parent into Many2One. | ||
| 2008-07-11 22:11 -!- kultviech(n=kultviec@p5B0D110D.dip0.t-ipconnect.de) has left #tryton | ||
| 2008-07-11 23:05 -!- yangoon3(n=mathiasb@p549F4D97.dip.t-dialin.net) has joined #tryton | ||
| 2008-07-11 23:19 <CIA-53> tryton: Bertrand Chenal <bch@b2ck.com> default * 159:768706443c07 stock/ (inventory.py location.py location.xml product.py product.xml): Improved stock computation behaviour |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!